Skip to content

MINOR: Cleanup Connect Module (3/n) #20156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

sjhajharia
Copy link
Contributor

@sjhajharia sjhajharia commented Jul 11, 2025

Now that Kafka support Java 17, this PR makes some changes in connect
module. The changes in this PR are limited to only some files. A future
PR(s) shall follow.

The changes mostly include:

  • Collections.emptyList(), Collections.singletonList() and Arrays.asList() are replaced with List.of()
  • Collections.emptyMap() and Collections.singletonMap() are replaced with Map.of()
  • Collections.singleton() is replaced with Set.of()

Modules target: runtime/src/test

@github-actions github-actions bot added triage PRs from the community connect tests Test fixes (including flaky tests) labels Jul 11, 2025
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @sjhajharia for this patch, left one comment

@github-actions github-actions bot removed the triage PRs from the community label Jul 15, 2025
@sjhajharia
Copy link
Contributor Author

Thanks @m1a2st for the comment. I have addressed the same at all locations where it is possible. Requesting a re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved connect tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants