pyspark: Improve SparkConf typing #51100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now SparkConf accepts any iterable, but the type annotation says
it only accepts list of tuples, so the following code works at runtime,
but fails in mypy:
```python
from pyspark.conf import SparkConf
d = {"a": "b"}
SparkConf().setAll(d.items())
```
mypy output:
```
tmp.py:4: error: Argument 1 to "setAll" of "SparkConf" has incompatible type "dict_items[str, str]"; expected "list[tuple[str, str]]" [arg-type]
Found 1 error in 1 file (checked 1 source file)
```
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Better type hints for
SparkConfclass for mypy and other python type checkersWhy are the changes needed?
Right now SparkConf accepts any iterable, but the type annotation says it only accepts a list, so the following code works at runtime, but fails in mypy:
mypy output:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually, by running mypy
Was this patch authored or co-authored using generative AI tooling?
No