Skip to content

Conversation

yuexing
Copy link
Contributor

@yuexing yuexing commented Jun 7, 2025

What changes were proposed in this pull request?

see https://issues.apache.org/jira/browse/SPARK-42841, replace _LEGACY_ERROR_TEMP_2005 with a meaningful name. Some points:

  • To make sure full UT coverage, method with "datatype" is refactored to call another one with "string".
  • sqlStat '0A000' means NOT_SUPPORTED or CANNOT.

Why are the changes needed?

see https://issues.apache.org/jira/browse/SPARK-42841

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Jun 7, 2025
@LuciferYang LuciferYang changed the title [SPARK-42841][SQL]Assign a name to the error class _LEGACY_ERROR_TEMP… [SPARK-42841][SQL]Assign a name to the error class _LEGACY_ERROR_TEMP_2005 Jun 7, 2025
"message" : [
"Type <dataType> does not support ordered operations."
],
"sqlState" : "0A000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @MaxGekk FYI
Is this sqlState correct?

@yuexing
Copy link
Contributor Author

yuexing commented Jun 17, 2025

friendly ping @MaxGekk

@LuciferYang
Copy link
Contributor

also cc @srielau

Copy link
Contributor

@srielau srielau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 0A000 seems appropriate given that order can always(?) be defined later.

@LuciferYang
Copy link
Contributor

needs to be rebased.

@yuexing
Copy link
Contributor Author

yuexing commented Jun 17, 2025

needs to be rebased.

okk, ing. Thanks!

@LuciferYang
Copy link
Contributor

LuciferYang commented Jun 17, 2025

image

all test passed

@LuciferYang
Copy link
Contributor

Merged into master.Thanks @yuexing @srielau

haoyangeng-db pushed a commit to haoyangeng-db/apache-spark that referenced this pull request Jun 25, 2025
…P_2005

### What changes were proposed in this pull request?
see https://issues.apache.org/jira/browse/SPARK-42841, replace _LEGACY_ERROR_TEMP_2005 with a meaningful name.  Some points:
- To make sure full UT coverage, method with "datatype" is refactored to call another one with "string".
- sqlStat '0A000' means NOT_SUPPORTED or CANNOT.

### Why are the changes needed?
see https://issues.apache.org/jira/browse/SPARK-42841

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
UT

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#51110 from yuexing/SPARK-42841-2005.

Lead-authored-by: xingyue <xingyue@baidu.com>
Co-authored-by: Yue <xingyue@baidu.com>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants