-
Notifications
You must be signed in to change notification settings - Fork 469
Add support for displaying numpy scalars #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benfred
merged 13 commits into
benfred:master
from
peytondmurray:744-numpy-scalar-support
Jul 13, 2025
Merged
Add support for displaying numpy scalars #752
benfred
merged 13 commits into
benfred:master
from
peytondmurray:744-numpy-scalar-support
Jul 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
reviewed
Jul 12, 2025
benfred
reviewed
Jul 13, 2025
Hey, just saw this - thanks for helping this across the finish line 🎉 |
thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for displaying the values of numpy scalars. Closes #744.
Following the pattern set forth elsewhere in
python_data_access.rs
, I used the raw pointer address of the numpy scalar to be printed. Since numpy scalars all have similar structs, e.g.where
obval
can be of different sizes, I just advance the pointer to the scalar by the size ofPyObject
, and then use thevalue_type_name
to know how many bytes to read. This approach avoids the need to generate numpy bindings, though if the structure of numpy scalars changes in the future we'll have to update.Note that this only works for uint8-64, int8-64, float32-64, and bool types; other types are not printed (half-precision and 128-bit floats aren't supported with native rust types yet although there is an RFC for them, and neither are complex numbers).