[Kernel] [CatalogManaged] Add the catalog managed preview table feature (read) support #4686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
changed the title
scottsand-db
changed the title
scottsand-db
commented
Jun 2, 2025
| public static boolean isRowTrackingSupported(Protocol protocol) { | ||
| return protocol.getImplicitlyAndExplicitlySupportedFeatures().contains(ROW_TRACKING_W_FEATURE); | ||
| return protocol.supportsFeature(ROW_TRACKING_W_FEATURE); |
There was a problem hiding this comment.
.supportsFeature calls .getImplicitlyAndExplicitlySupportedFeatures().contains
huan233usc
approved these changes
Jun 3, 2025
scottsand-db
force-pushed
the
stack/kernel_catalog_managed_table_feature
branch
from
65f7212 to
a9b0bcb
Compare
|
LGTM pending nits. |
raveeram-db
approved these changes
Jun 13, 2025
kernel/kernel-api/src/main/java/io/delta/kernel/internal/tablefeatures/TableFeatures.java
Outdated
Show resolved
Hide resolved
...s/src/test/scala/io/delta/kernel/defaults/catalogManaged/CatalogManagedEnablementSuite.scala
Outdated
Show resolved
Hide resolved
vkorukanti
approved these changes
Jun 13, 2025
| // `delta.feature.catalogOwned-preview` correctly enables the catalogManaged table feature. | ||
| // When writer support is added, we will extend this test to check that the right properties | ||
| // and table features (e.g. ICT) were enabled. | ||
| test("setting delta.feature.catalogOwned-preview enables the catalogManaged table feature") { |
There was a problem hiding this comment.
If this is the only test, add it to DeltaTableFeaturesSuite
There was a problem hiding this comment.
I anticipate we will have more tests:
scottsand-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
Creates the
CATALOG_MANAGED_R_W_FEATURE_PREVIEW. Only read support.Note -- only merge when full read support is complete. But this can be reviewed now.
How was this patch tested?
Existing UTs.
Does this PR introduce any user-facing changes?
No.