[Kernel][#2] IcebergCompatV3 - move IcebergCompatCheck to base class #4732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzlfred
approved these changes
Jun 10, 2025
5 tasks
vkorukanti
requested changes
Jun 10, 2025
...in/java/io/delta/kernel/internal/icebergcompat/IcebergCompatMetadataValidatorAndUpdater.java
Outdated
Show resolved
Hide resolved
| } | ||
| }; | ||
|
|
||
| protected static final IcebergCompatCheck CHECK_HAS_ALLOWED_PARTITION_TYPES = |
There was a problem hiding this comment.
add a comment, these are the common supported partition types for compatv2 and v3
Comment on lines
+259
to
+260
| // TODO: Kernel doesn't support replace table yet. When it is supported, extend | ||
| // this to allow checking the partition columns aren't changed |
There was a problem hiding this comment.
do you know what we need here given Delta doesn't support changing the partition columns?
There was a problem hiding this comment.
replace table should support change partition columns in the future? And if that is supported, we need to update this check?
vkorukanti
approved these changes
Jun 11, 2025
vkorukanti
pushed a commit
that referenced
this pull request
Jun 17, 2025
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> Introduce IcebergCompatV3 feature, which requires row tracking and column mapping to be enabled. We block the disabling or enabling IcebergCompatV3 on existing tables. This PR is a stacked PR and based on #4731 and #4732 ## How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> Unit tests and e2e tests. ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR is refactoring only, move all the IcebergCompatChecks from
IcebergCompatV2MetadataValidatorAndUpdater.javato its base classIcebergCompatMetadataValidatorAndUpdater.javaso that later newly addedIcebergCompatV3MetadataValidatorAndUpdater.javacan use them.How was this patch tested?
Existing unit tests since it is only doing refactoring.
Does this PR introduce any user-facing changes?