[Kernel] Update max id to use SchemaIterable #4742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| .stream() | ||
| .mapToInt( | ||
| e -> { | ||
| int columnId = hasColumnId(e.getField()) ? getColumnId(e.getField()) : 0; |
There was a problem hiding this comment.
btw -- what do you think of (later) being able to do e.getField().hasColumnId and e.getField().getColumnId?
Today it seems like we have this strange c struct way of poking at our data?
There was a problem hiding this comment.
I think this might be part of a larger refactor, because getColumnId might be a little weird when we start talking about nested types. If we push all IDs down into the schema and without metadata I think it makes sense, otherwise keeping it more private (like it is today as a non-OO method is probably the right direction).
TL;DR; This is probably blocked on deciding how things we stuff in FieldMetadata are abstracted to end-users.
scottsand-db
approved these changes
Jun 12, 2025
This was referenced Jun 12, 2025
emkornfield
force-pushed
the
stack/schemaIdToSchemaIterable
branch
from
08842ac to
b60855c
Compare
5 tasks
emkornfield
force-pushed
the
stack/schemaIdToSchemaIterable
branch
from
b60855c to
4631f20
Compare
vkorukanti
pushed a commit
that referenced
this pull request
Jun 17, 2025
## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta/pull/4752/files/4631f204cf59016d876a0c3bd408e7c67112b22b..19c2fe51f33bba7e4e584874238884d04bef514e) to review incremental changes. - [stack/schemaIdToSchemaIterable](#4742) [[Files changed](https://github.com/delta-io/delta/pull/4742/files)] - [**stack/update_table_features**](#4752) [[Files changed](https://github.com/delta-io/delta/pull/4752/files/4631f204cf59016d876a0c3bd408e7c67112b22b..19c2fe51f33bba7e4e584874238884d04bef514e)] - [stack/update_validators](#4753) [[Files changed](https://github.com/delta-io/delta/pull/4753/files/19c2fe51f33bba7e4e584874238884d04bef514e..378a8eda53800bcbfffc648459f5b0af69fdfffc)] - [stack/remove_recurse_from_schema_utils](#4754) [[Files changed](https://github.com/delta-io/delta/pull/4754/files/378a8eda53800bcbfffc648459f5b0af69fdfffc..c4c744aa0f7e6601da7b2d12254eeb0360d9ca13)] --------- #### Which Delta project/connector is this regarding? - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description Migrate to using SchemaIterable for checking for table features. Relates to https://github.com/delta-io/delta/issues/4744Relates to #4744 ## How was this patch tested? Existing tests ## Does this PR introduce _any_ user-facing changes? No
vkorukanti
pushed a commit
that referenced
this pull request
Jun 17, 2025
## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta/pull/4753/files/19c2fe51f33bba7e4e584874238884d04bef514e..378a8eda53800bcbfffc648459f5b0af69fdfffc) to review incremental changes. - [stack/schemaIdToSchemaIterable](#4742) [[Files changed](https://github.com/delta-io/delta/pull/4742/files)] - [stack/update_table_features](#4752) [[Files changed](https://github.com/delta-io/delta/pull/4752/files/4631f204cf59016d876a0c3bd408e7c67112b22b..19c2fe51f33bba7e4e584874238884d04bef514e)] - [**stack/update_validators**](#4753) [[Files changed](https://github.com/delta-io/delta/pull/4753/files/19c2fe51f33bba7e4e584874238884d04bef514e..378a8eda53800bcbfffc648459f5b0af69fdfffc)] - [stack/remove_recurse_from_schema_utils](#4754) [[Files changed](https://github.com/delta-io/delta/pull/4754/files/378a8eda53800bcbfffc648459f5b0af69fdfffc..c4c744aa0f7e6601da7b2d12254eeb0360d9ca13)] --------- #### Which Delta project/connector is this regarding? - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description Updates validators to use streams instead of filterRecursively. This makes the code more idiomatic, with less hops. Relates to #4744 ## How was this patch tested? Existing tests. ## Does this PR introduce _any_ user-facing changes? No
vkorukanti
pushed a commit
that referenced
this pull request
Jun 17, 2025
## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta/pull/4754/files/378a8eda53800bcbfffc648459f5b0af69fdfffc..c4c744aa0f7e6601da7b2d12254eeb0360d9ca13) to review incremental changes. - [stack/schemaIdToSchemaIterable](#4742) [[Files changed](https://github.com/delta-io/delta/pull/4742/files)] - [stack/update_table_features](#4752) [[Files changed](https://github.com/delta-io/delta/pull/4752/files/4631f204cf59016d876a0c3bd408e7c67112b22b..19c2fe51f33bba7e4e584874238884d04bef514e)] - [stack/update_validators](#4753) [[Files changed](https://github.com/delta-io/delta/pull/4753/files/19c2fe51f33bba7e4e584874238884d04bef514e..378a8eda53800bcbfffc648459f5b0af69fdfffc)] - [**stack/remove_recurse_from_schema_utils**](#4754) [[Files changed](https://github.com/delta-io/delta/pull/4754/files/378a8eda53800bcbfffc648459f5b0af69fdfffc..c4c744aa0f7e6601da7b2d12254eeb0360d9ca13)] --------- #### Which Delta project/connector is this regarding? - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description Remove last usages of filterRecursively in favor of SchemaIterable. Relates to #4744 ## How was this patch tested? Existing tests. ## Does this PR introduce _any_ user-facing changes? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
This PR refactors findMaxId to use schema iterable.
Relates to #4744
How was this patch tested?
Existing unit tests.
Does this PR introduce any user-facing changes?
No.