Skip to content

msvc + ninja + modules: Fix build when consuming fmtlib while using a Ninja generator #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2025
Merged

msvc + ninja + modules: Fix build when consuming fmtlib while using a Ninja generator #4495

merged 1 commit into from
Jul 13, 2025

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort commented Jul 12, 2025 •
edited
Loading

Fixes #4491.

Generator fmtlib -> consumer Type Old New
VS -> VS * Works Works
VS -> Ninja find_package Works Works
VS -> Ninja add_submodule Broken Works
Ninja -> VS find_package Broken Broken
Ninja -> VS add_submodule Works Works
Ninja -> Ninja find_package Broken Works
Ninja -> Ninja add_submodule Broken Works

@vitaut vitaut merged commit a0ecfe3 into fmtlib:master Jul 13, 2025
40 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jul 13, 2025

Thank you

@autoantwort autoantwort deleted the fix-modules-with-msvc-and-ninja branch July 13, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using installed c++ module with MSVC
2 participants
@autoantwort @vitaut