-
Notifications
You must be signed in to change notification settings - Fork 38
feat: added support for disable tracing by groups #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
390a561
to
fc32541
Compare
15ef76a
to
f52ea3f
Compare
ccf80ce
to
bcde185
Compare
0d4f438
to
017b25e
Compare
8c28038
to
bf2e7b1
Compare
bf2e7b1
to
69e227c
Compare
if (!normalizedEntry) return; | ||
|
||
// The supported groups are predefined in DISABLABLE_INSTRUMENTATION_GROUPS. | ||
// If the entry matches one of these, we classify it as a group, otherwise, considered as an instrumentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The disable config can be a flat list like ['redis', 'logging']. Internally, we have two lists: instrumentations and groups. If an entry matches a known group (defined in constants), we add it to the groups list. Everything else goes into the instrumentations list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
Previously, tracing could only be selectively disabled at the package level.
With this changes, tracing can now also be disabled at the group level.
New Configuration Options
1. Environment Variables
INSTANA_TRACING_DISABLE_INSTRUMENTATIONS=console,redis #incorporated in last PR
2. In-Code
To disable specific instrumentations or groups:
Or using flat shorthand:
TODO
INSTANA_TRACING_DISABLE=true
(in a separate PR)References