test: improved http vs https handling #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
fix-tlsgg
branch
2 times, most recently
from
132e8ec to
1d2e2ff
Compare
kirrg001
changed the title
kirrg001
commented
Jun 17, 2025
| // we need to disable the TLS certificate check, otherwise the request will fail. | ||
| // Refer to the problem discussed in https://github.com/node-fetch/node-fetch/issues/1 | ||
| if (this.backendUsesHttps) { | ||
| process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0'; |
There was a problem hiding this comment.
We do not set NODE_TLS_REJECT_UNAUTHORIZED globally for a whole test env.
Only if the backend / app runs in https and we use self signed certs.
kirrg001
commented
Jun 17, 2025
| DOWNSTREAM_DUMMY_URL: this.downstreamDummyUrl, | ||
| INSTANA_DISABLE_CA_CHECK: true, | ||
| INSTANA_DEV_SEND_UNENCRYPTED: this.opts.backendUsesHttps ? 'false' : 'true', |
There was a problem hiding this comment.
HTTP is default for the test env and sending INSTANA_DEV_SEND_UNENCRYPTED will allow to use an http endpoint.
aryamohanan
approved these changes
Jun 18, 2025
- NODE_TLS_REJECT_UNAUTHORIZED can create a log.console span - HTTPS without certification -> creates a node warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems: