Skip to content

Conversation

cidlik
Copy link
Contributor

@cidlik cidlik commented Feb 2, 2025

Description
According to [1] add_color_level() is a method of ColoredLevelFormatter
only. The exception AttributeError is raised for other formatters.

[1] https://github.com/pytest-dev/pytest/blob/main/src/_pytest/logging.py#L104

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested
  • Man pages have been regenerated

Emantor
Emantor previously approved these changes Feb 4, 2025
@Emantor
Copy link
Member

Emantor commented Feb 4, 2025

Thanks for the PR, this is missing a DCO, you can add this with git commit --amend -s and doing a force push to the branch.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.8%. Comparing base (bee565c) to head (45ea783).
⚠️ Report is 102 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1592   +/-   ##
======================================
  Coverage    55.8%   55.8%           
======================================
  Files         170     170           
  Lines       13388   13389    +1     
======================================
+ Hits         7472    7473    +1     
  Misses       5916    5916           
Flag Coverage Δ
3.10 55.8% <100.0%> (+<0.1%) ⬆️
3.11 55.8% <100.0%> (+<0.1%) ⬆️
3.12 55.8% <100.0%> (+<0.1%) ⬆️
3.13 55.7% <100.0%> (+<0.1%) ⬆️
3.9 55.8% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cidlik cidlik force-pushed the add-color-level-issue branch from 2c6c3b8 to 36a898a Compare February 4, 2025 18:30
@cidlik cidlik requested a review from Emantor February 6, 2025 07:08
@Emantor Emantor force-pushed the add-color-level-issue branch from 0b5172b to 4d98bb2 Compare February 17, 2025 07:06
@Emantor
Copy link
Member

Emantor commented Feb 17, 2025

Your name in the DCO matches, but the email adress does not.

@cidlik
Copy link
Contributor Author

cidlik commented Feb 23, 2025

Your name in the DCO matches, but the email adress does not.

Yeap, sorry, it's my bad

@cidlik cidlik removed their assignment Feb 26, 2025
According to [1] add_color_level() is a method of ColoredLevelFormatter
only.

[1] https://github.com/pytest-dev/pytest/blob/main/src/_pytest/logging.py#L104

Change-Id: Iaa67c613b196b9cbbbc930d547edaa784d545130
Signed-off-by: Roman Kuznecov <zubastikiko@gmail.com>
@Emantor Emantor force-pushed the add-color-level-issue branch from c3fcb39 to 45ea783 Compare June 19, 2025 14:15
@Emantor Emantor merged commit c3a2b67 into labgrid-project:master Jun 19, 2025
11 checks passed
@Bastian-Krause Bastian-Krause added the pick to stable Needs a pick to the latest stable branch label Jun 21, 2025
@Bastian-Krause Bastian-Krause added picked to stable Already picked to the latest stable branch. and removed pick to stable Needs a pick to the latest stable branch labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
picked to stable Already picked to the latest stable branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants