[12] graph/db: Implement more graph SQLStore methods #9936

ellemouton · 2025-06-12T09:20:12Z

Here, we implement:

ChanUpdatesInHorizon
ForEachNodeCached
ForEachChannel
FilterChannelRange

Part of #9795
See #9932 for the full picture that we are aiming at

coderabbitai · 2025-06-12T09:20:18Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

lightninglabs-deploy · 2025-06-19T11:11:41Z

@bhandras: review reminder

guggero

Very nice, LGTM 🎉

sqldb/sqlc/queries/graph.sql

guggero · 2025-06-20T12:14:31Z

sqldb/sqlc/queries/graph.sql

+        ON cp2.channel_id = c.id AND cp2.node_id = c.node_id_2 AND cp2.version = c.version
+WHERE c.version = sqlc.arg(version)
+  AND (cp1.last_update >= sqlc.arg(start_time) AND cp1.last_update < sqlc.arg(end_time)
+    OR cp2.last_update >= sqlc.arg(start_time) AND cp2.last_update < sqlc.arg(end_time))


nit: use parenthesis around AND clause to make precedence explicit for easier visual parsine.

good idea! lemme know if the update looks ok

sqldb/sqlc/queries/graph.sql

graph/db/sql_store.go

sqldb/sqlc/queries/graph.sql

Abdulkbk

Reviewed for my learning, left just one comment

graph/db/sql_store.go

bhandras

Looks good, just one last comment.

graph/db/sql_store.go

Add `ChanUpdatesInHorizon` method to the SQLStore. This lets us run `TestChanUpdatesInHorizon` against our SQL backends.

Ensure that the log line in `ChanUpdatesInHorizon` cannot cause a divide-by-zero panic.

So that we can have efficient lookups during the "*UpdatesInHorizon" calls.

Which let's us run `TestGraphTraversal` against our SQL backends.

This lets us run `TestFilterChannelRange` against the SQL backends.

bhandras

LGTM 🎉

bhandras · 2025-06-24T12:34:54Z

graph/db/sql_store.go

+	}
+
+	if len(edges) > 0 {
+		log.Debugf("ChanUpdatesInHorizon hit percentage: %f (%d/%d)",


nit: if we're logging percentage, we should also multiply the result by 100. Also maybe worth fixing the precision to say %.2f.

cool, can do 👍 if it's ok, im gonna add this as a commit in the next PR so we can get this one in 👍 will make a note there

added a commit here: #9971

ellemouton added this to the v0.20.0 milestone Jun 12, 2025

ellemouton self-assigned this Jun 12, 2025

ellemouton added graph sql labels Jun 12, 2025

ellemouton mentioned this pull request Jun 12, 2025

[13] graph/db: SQL-ize the zombie index #9937

Merged

ellemouton requested a review from bhandras June 12, 2025 10:14

ellemouton changed the base branch from elle-graph12 to master June 19, 2025 13:11

ellemouton force-pushed the graphSQL12 branch from 5e8b169 to 2ee302a Compare June 19, 2025 13:11

ellemouton requested a review from guggero June 19, 2025 14:00

ellemouton force-pushed the graphSQL12 branch 2 times, most recently from 01d561e to aeeee0e Compare June 20, 2025 10:01

guggero approved these changes Jun 20, 2025

View reviewed changes

ellemouton force-pushed the graphSQL12 branch 2 times, most recently from 9ca966b to 5670158 Compare June 20, 2025 12:56

Abdulkbk reviewed Jun 23, 2025

View reviewed changes

graph/db/sql_store.go Outdated Show resolved Hide resolved

bhandras reviewed Jun 24, 2025

View reviewed changes

graph/db/sql_store.go Outdated Show resolved Hide resolved

ellemouton force-pushed the graphSQL12 branch from 5670158 to bd5d95f Compare June 24, 2025 10:17

ellemouton added 5 commits June 24, 2025 12:17

graph/db+sqldb: implement ChanUpdatesInHorizon

39e521e

Add `ChanUpdatesInHorizon` method to the SQLStore. This lets us run `TestChanUpdatesInHorizon` against our SQL backends.

graph/db: fix log line in KVStore

5bb5b6a

Ensure that the log line in `ChanUpdatesInHorizon` cannot cause a divide-by-zero panic.

sqldb: add index on node & chan policy last_update columns

6aa2933

So that we can have efficient lookups during the "*UpdatesInHorizon" calls.

graph/db+sqldb: impl ForEachNodeCached and ForEachChannel

ff84fa1

Which let's us run `TestGraphTraversal` against our SQL backends.

sqldb+graph/db: implement FilterChannelRange

3687171

This lets us run `TestFilterChannelRange` against the SQL backends.

ellemouton force-pushed the graphSQL12 branch from bd5d95f to 3687171 Compare June 24, 2025 10:18

ellemouton requested a review from bhandras June 24, 2025 10:47

bhandras approved these changes Jun 24, 2025

View reviewed changes

ellemouton merged commit 6b80796 into lightningnetwork:master Jun 24, 2025
33 of 38 checks passed

ellemouton deleted the graphSQL12 branch June 24, 2025 12:37

[12] graph/db: Implement more graph SQLStore methods #9936

[12] graph/db: Implement more graph SQLStore methods #9936

Uh oh!

Conversation

ellemouton commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

lightninglabs-deploy commented Jun 19, 2025

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

guggero Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

ellemouton Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Abdulkbk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bhandras left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bhandras left a comment

Choose a reason for hiding this comment

Uh oh!

bhandras Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

ellemouton Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

ellemouton Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ellemouton commented Jun 12, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)