[15] graph/db: SQL prune log #9939

ellemouton · 2025-06-12T09:39:28Z

Here we add the schema, queries and CRUD for the prune log. The following methods are implemented:

PruneGraphNodes
PruneGraph
PruneTip
ChannelView
DisconnectBlockAtHeight

Part of #9795
Depends on #9938
See #9932 for the full picture that we are aiming at

coderabbitai · 2025-06-12T09:39:58Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

guggero

Very nice!

sqldb/sqlc/migrations/000007_graph.up.sql

guggero · 2025-06-23T08:21:33Z

graph/db/sql_store.go

+			err)
+	}
+
+	nodeID, _, err := s.getSourceNode(ctx, db, ProtocolV1)


Not sure how you are planning on doing the whole V2 stuff, but perhaps the version could be a parameter to this method so in the future it can just be called twice, once for each version?

Or I guess since GetUnconnectedNodes returns nodes for both versions, the two different versions would be handled in the loop below?

great catch. Going to update this to work across any protocol since the rule of "what is an unconnected node" stays the same.

Going to update the GetUnconnectedNodes to ignore any nodes in the source_nodes table

sqldb/sqlc/queries/graph.sql

graph/db/sql_store.go

sqldb/sqlc/migrations/000007_graph.up.sql

ellemouton · 2025-06-24T12:14:47Z

graph/db/sql_store.go

+			err)
+	}
+
+	nodeID, _, err := s.getSourceNode(ctx, db, ProtocolV1)


great catch. Going to update this to work across any protocol since the rule of "what is an unconnected node" stays the same.

Going to update the GetUnconnectedNodes to ignore any nodes in the source_nodes table

graph/db/sql_store.go

sqldb/sqlc/queries/graph.sql

ellemouton · 2025-06-24T13:11:36Z

graph/db/sql_store.go

+		for _, outpoint := range spentOutputs {
+			row, err := db.GetChannelByOutpoint(
+				ctx, sqlc.GetChannelByOutpointParams{
+					Outpoint: outpoint.String(),


NOTE: i've updated the GetChannelByOutpointParams query to no longer have the version caveat since:

our prune log is not protocol version dependent. So if an entry is there, it must mean the prune is complete for all versions.

So we want to ensure that PruneGraph & PruneGraphNodes are both protocol independent. For now: PruneGraph will error when getAndBuildEdgeInfo is called for a non-V1 channel since the method requires us to build the full in-memory model of the channel & we dont have that defined for v2 channels yet.

guggero

LGTM 🎉

Define the schema for the prune log.

Which lets us run `TestChannelEdgePruningUpdateIndexDeletion` against our SQL backends.

bhandras

LGTM 🎉

graph/db/sql_store.go

Which lets us run `TestGraphPruning` and `TestBatchedAddChannelEdge` against our SQL backends.

Which lets us run `TestDisconnectBlockAtHeight` and `TestStressTestChannelGraphAPI` against our SQL backends.

ellemouton added this to the v0.20.0 milestone Jun 12, 2025

ellemouton self-assigned this Jun 12, 2025

ellemouton added graph pruning sql labels Jun 12, 2025

ellemouton mentioned this pull request Jun 20, 2025

[epic]: graph db: SQL implementation & migration #9795

Closed

84 tasks

ellemouton force-pushed the elle-graph15 branch from b2b9dac to f909068 Compare June 20, 2025 14:14

ellemouton force-pushed the graphSQL15-prune-log branch from cd16adc to 71d907c Compare June 20, 2025 14:15

ellemouton mentioned this pull request Jun 20, 2025

[16] graph/db: SQL closed SCIDs table and last few methods #9971

Merged

ellemouton force-pushed the graphSQL15-prune-log branch from 71d907c to dc2182d Compare June 23, 2025 07:42

ellemouton requested review from guggero and bhandras June 23, 2025 08:12

guggero reviewed Jun 23, 2025

View reviewed changes

ellemouton force-pushed the elle-graph15 branch from f909068 to 4578b8a Compare June 24, 2025 13:15

ellemouton force-pushed the graphSQL15-prune-log branch from dc2182d to 6aac2f9 Compare June 24, 2025 13:15

ellemouton commented Jun 24, 2025

View reviewed changes

ellemouton requested a review from guggero June 24, 2025 14:05

guggero approved these changes Jun 24, 2025

View reviewed changes

ellemouton added 2 commits June 25, 2025 10:48

sqldb/sqlc: prune_log schema

102c04d

Define the schema for the prune log.

graph/db+sqldb: impl PruneGraphNodes

2da701c

Which lets us run `TestChannelEdgePruningUpdateIndexDeletion` against our SQL backends.

ellemouton changed the base branch from elle-graph15 to master June 25, 2025 08:49

ellemouton force-pushed the graphSQL15-prune-log branch from 6aac2f9 to 78fc052 Compare June 25, 2025 08:49

bhandras approved these changes Jun 25, 2025

View reviewed changes

graph/db/sql_store.go Show resolved Hide resolved

ellemouton added 2 commits June 25, 2025 11:22

graph/db+sqldb: impl PruneGraph, PruneTip, ChannelView

9dd0361

Which lets us run `TestGraphPruning` and `TestBatchedAddChannelEdge` against our SQL backends.

sqldb+graph/db: impl DisconnectBlockAtHeight

e875183

Which lets us run `TestDisconnectBlockAtHeight` and `TestStressTestChannelGraphAPI` against our SQL backends.

ellemouton force-pushed the graphSQL15-prune-log branch from 78fc052 to e875183 Compare June 25, 2025 09:22

ellemouton merged commit 5d926b3 into lightningnetwork:master Jun 25, 2025
37 of 38 checks passed

ellemouton deleted the graphSQL15-prune-log branch June 25, 2025 11:24

[15] graph/db: SQL prune log #9939

[15] graph/db: SQL prune log #9939

Uh oh!

Conversation

ellemouton commented Jun 12, 2025

Uh oh!

coderabbitai bot commented Jun 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

guggero Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

ellemouton Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ellemouton Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ellemouton Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

bhandras left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)