Refactor storage tests to support testing multiple backends on schema changes #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
bpkroth
added
WIP
There was a problem hiding this comment.
Pull Request Overview
Refactors the storage test suite to enable running MySQL and PostgreSQL backends alongside SQLite, updates schema-reset helpers, and aligns config files accordingly
- Adds session‐scoped fixtures and helper functions for MySQL/PostgreSQL servers via
pytest-docker - Introduces
_reset_schemaanddrop_all_tablesmethods to clear test schemas after each run - Provides Docker Compose files, up/down scripts, and updates JSONC storage configs to use the
mlos_benchdatabase
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/storage/sql/fixtures.py | Added MySQL/Postgres fixtures and context manager |
| tests/storage/sql/docker-compose.yml | Defined MySQL/Postgres services for testing |
| tests/storage/sql/down.sh | Manual teardown script for SQL test containers |
| tests/storage/sql/init.py | Declared server names and SqlTestServerInfo class |
| tests/storage/conftest.py | Exposed new storage fixtures in the root conftest |
| tests/conftest.py | Added docker_hostname fixture and included SQL compose file |
| storage/sql/storage.py | Added _reset_schema for test cleanup |
| storage/sql/schema.py | Made col‐length constants instance attributes; added drop_all_tables |
| storage/sql/alembic/README.md / alembic.ini | Expanded Alembic workflow for multiple backends |
| config/storage/mysql.jsonc / postgresql.jsonc | Corrected database name to mlos_bench |
| tests/services/remote/ssh/… | Switched SSH fixtures to use docker_hostname and wait_docker_service_socket |
Comments suppressed due to low confidence (4)
mlos_bench/mlos_bench/tests/storage/sql/fixtures.py:118
- The
jsonmodule is not imported in this file; addimport jsonat the top.
global_configs=[json.dumps(global_config)],
mlos_bench/mlos_bench/tests/storage/sql/fixtures.py:154
- The docstring refers to "MySQL" for the
postgres_storagefixture; update it to PostgreSQL.
"""
Fixture of a MySQL backed SqlStorage engine.
"""
mlos_bench/mlos_bench/tests/storage/sql/init.py:55
- The docstring in
get_portmentions SSH; adjust to reference the SQL test server.
"""
Gets the port that the SSH test server is listening on.
"""
mlos_bench/mlos_bench/tests/conftest.py:38
- The
sysmodule is used but not imported; addimport sysat the top of this file.
if sys.platform != "win32" and resolve_host_name(HOST_DOCKER_NAME):
motus
approved these changes
Jun 12, 2025
bpkroth
added a commit
that referenced
this pull request
Jun 13, 2025
# Pull Request ## Title MySQL schema change to support fractional time ______________________________________________________________________ ## Description - Changes the storage schema to support a variant for MySQL that can handle fractional time. - Adds a custom column comparator to be able to pick that up by default in the future. - Adjusts tests to check for fractional time support. ______________________________________________________________________ ## Type of Change - 🛠️ Bug fix - ✨ New feature - 🔄 Refactor - 🧪 Tests ______________________________________________________________________ ## Testing - A lot of manual testing with docker. - Additional CI tests - Existing CI tests ______________________________________________________________________ ## Additional Notes (optional) Part of a series of changes, should be merged after #983 ______________________________________________________________________ --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Refactor storage tests to support testing multiple backends on schema changes
Description
Type of Change
Testing
Additional Notes (optional)
Part of a series of changes to help improve testing for schedulers.
Next will be schema changes to allow storing fractional seconds in MySQL.
Merge after #987