Enable SSH Generator Feature Flag

[carlos-zamora]

Enables the SSH Dynamic Profile Generator feature flag now that the Settings UI is better equipped to handle it. Since the generator was first introduced, the settings UI has grown to include an Extensions page to disable the generator (if desired) as well as a New Tab Menu page to manage how to display the generated profiles in the dropdown.

Targets #18633

Closes #15007

[carlos-zamora]

[lhecker]

Does this add the SSH profiles by default already? I know we've in the past talked about adding profiles only when the user wants them, so I was wondering if we're making that part of 1.24...

[lhecker]

Seems like this should be AlwaysEnabled then?

[carlos-zamora]

Nope! The SSH code is hidden behind a feature flag on Stable builds so I'm making sure we still don't expose it yet. I want to make sure the experience feels right with the Extensions page. Once the Extensions page goes to Stable, we can just remove the feature flag altogether.

WindowsInbox is also one that's omitted. Same deal there.

[carlos-zamora]

Does this add the SSH profiles by default already? I know we've in the past talked about adding profiles only when the user wants them, so I was wondering if we're making that part of 1.24...

Yeah, the profiles are added by default, but can be managed using disabledProfileSources in the JSON or the Extensions page in the SUI.

The concept of "disabling by default" is a bit difficult here because we'd have to patch disabledProfileSources to include the SSH generator. I think the way we've handled that before is by updating defaults.json. That way anybody that has disabledProfileSources defined in their settings.json is unaffected vs those who don't have it defined inherit it.

Happy to add that change in, but I just want to make sure we have consensus. I'll start a thread.

[DHowett]

Let's hold for the discussion.