-
Notifications
You must be signed in to change notification settings - Fork 89
Add a button to use replicates for comparisons when available #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
beatrice-acasandrei
wants to merge
2
commits into
mozilla:main
Choose a base branch
from
beatrice-acasandrei:enable-replicates-for-statistics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add a button to use replicates for comparisons when available #895
beatrice-acasandrei
wants to merge
2
commits into
mozilla:main
from
beatrice-acasandrei:enable-replicates-for-statistics
+196
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
julienw
reviewed
Jun 16, 2025
src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap
Outdated
Show resolved
Hide resolved
julienw
reviewed
Jun 16, 2025
af613ec
to
a9582e5
Compare
5ef8c51
to
c03d4b9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
==========================================
- Coverage 95.45% 95.20% -0.26%
==========================================
Files 97 97
Lines 2709 2732 +23
Branches 550 554 +4
==========================================
+ Hits 2586 2601 +15
- Misses 121 129 +8
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c03d4b9
to
561797c
Compare
561797c
to
3ea1484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some exmples to look at:
Before: https://perf.compare/subtests-compare-results?baseRev=974421fd9d593416ba7308dbbaa7117096f68ad5&baseRepo=try&newRev=2c540969a27f657afc82f189d0c96280ac432d44&newRepo=try&framework=13&baseParentSignature=3444909&newParentSignature=3444909
After: https://deploy-preview-895--mozilla-perfcompare.netlify.app/subtests-compare-results?baseRev=974421fd9d593416ba7308dbbaa7117096f68ad5&baseRepo=try&newRev=2c540969a27f657afc82f189d0c96280ac432d44&newRepo=try&framework=13&baseParentSignature=3444909&newParentSignature=3444909&replicates=
Before: https://perf.compare/compare-lando-results?baseLando=140238&newLando=140239&baseRepo=try&newRepo=try&framework=13
After: https://deploy-preview-895--mozilla-perfcompare.netlify.app/compare-lando-results?baseLando=140238&newLando=140239&baseRepo=try&newRepo=try&framework=13&replicates=