-
Notifications
You must be signed in to change notification settings - Fork 407
feat: del blockToWebComponentTemplate #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: del blockToWebComponentTemplate #1347
Conversation
WalkthroughThe changes involve the complete removal of the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
💤 Files with no reviewable changes (5)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
designer-demo/bundle-deps/local-cdn/package.json (2)
2-2
: Validate thename
field.
Ensure the package name follows npm naming conventions and avoids naming collisions. You may consider adding an npm scope (e.g.,@opentiny/bundle-deps
) or appending-local-cdn
to clarify its purpose.
4-19
: Standardize dependency version specifiers.
The current mix of exact ("1.0.0"
), caret ("^9.9.0"
), and tilde ("~3.20"
) ranges can lead to inconsistent dependency updates. For maintainability, adopt a consistent versioning strategy—e.g., using caret ranges (^
) for non-breaking updates—or document why certain packages are pinned exactly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
designer-demo/bundle-deps/local-cdn/package.json
(1 hunks)packages/blockToWebComponentTemplate/README.md
(0 hunks)packages/blockToWebComponentTemplate/package.json
(0 hunks)packages/blockToWebComponentTemplate/src/BlockFileName.vue
(0 hunks)packages/blockToWebComponentTemplate/src/lib.js
(0 hunks)packages/blockToWebComponentTemplate/vite.config.js
(0 hunks)
💤 Files with no reviewable changes (5)
- packages/blockToWebComponentTemplate/README.md
- packages/blockToWebComponentTemplate/src/lib.js
- packages/blockToWebComponentTemplate/package.json
- packages/blockToWebComponentTemplate/src/BlockFileName.vue
- packages/blockToWebComponentTemplate/vite.config.js
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: push-check
2e16044
to
7ac74b6
Compare
7ac74b6
to
ca13b1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/solutions/block-lan-release-solution.md (1)
3-6
: Use standardized Markdown admonition for the deprecation warning
To align with the style in other docs (e.g.block-release-solution.md
), consider using a single-line admonition syntax such as:> [!WARNING] > From TinyEngine v2.1 onward, this block LAN release solution is no longer recommended. Please refer to the [new block construction solution](./block-construction-solution.md).This improves readability and consistency across documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
docs/solutions/block-construction-solution.md
(2 hunks)docs/solutions/block-lan-release-solution.md
(1 hunks)docs/solutions/block-release-solution.md
(1 hunks)packages/blockToWebComponentTemplate/README.md
(0 hunks)packages/blockToWebComponentTemplate/package.json
(0 hunks)packages/blockToWebComponentTemplate/src/BlockFileName.vue
(0 hunks)packages/blockToWebComponentTemplate/src/lib.js
(0 hunks)packages/blockToWebComponentTemplate/vite.config.js
(0 hunks)
💤 Files with no reviewable changes (5)
- packages/blockToWebComponentTemplate/src/lib.js
- packages/blockToWebComponentTemplate/README.md
- packages/blockToWebComponentTemplate/vite.config.js
- packages/blockToWebComponentTemplate/src/BlockFileName.vue
- packages/blockToWebComponentTemplate/package.json
✅ Files skipped from review due to trivial changes (2)
- docs/solutions/block-release-solution.md
- docs/solutions/block-construction-solution.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: push-check
758b2e2
to
4edb74e
Compare
4edb74e
to
68f15dd
Compare
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit