Generate .pyi files in py_proto_library (#10366) #21567
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We here adjust py_proto_library to produce `.pyi` files along with the `.py` files it already generates. This achieves the same effect as the gRPC py_proto_library. Closes protocolbuffers#10366.
|
+1; with |
anandolee
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
@anandolee Thanks for adding the tag! It looks like my PR passes CI, so I look forward to your review. |
mkruskal-google
added
python
bazel
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We here adjust py_proto_library to produce
.pyifiles along with the.pyfiles it already generates. This achieves the same effect as the gRPC py_proto_library.Closes #10366.