Fix MSYS-built protoc CLI invokation cases where an arg is an absolute path (#21244) #21575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_754377153
branch
2 times, most recently
from
00f273a to
2625a67
Compare
…e path (#21244) Without these changes, if the `protoc` binary is compiled from inside MSYS but gets invoked from the outside within the native Windows `cmd` shell environment, and one of the CLI arguments happens to be supplied as an absolute path string, then the `*.pb.*` code file generation process will fail with an error similar to the following sample output... ``` # MSYS: plbrooks@LAPTOP-DEADBEEF MSYS /c/UserData/Programming $ git clone https://github.com/protocolbuffers/protobuf.git plbrooks@LAPTOP-DEADBEEF MSYS /c/UserData/Programming $ cd protobuf plbrooks@LAPTOP-DEADBEEF MSYS /c/UserData/Programming/protobuf $ cd cmake plbrooks@LAPTOP-DEADBEEF MSYS /c/UserData/Programming/protobuf/cmake $ mkdir build plbrooks@LAPTOP-DEADBEEF MSYS /c/UserData/Programming/protobuf/cmake $ cd build plbrooks@LAPTOP-DEADBEEF MSYS /c/UserData/Programming/protobuf/cmake/build $ cmake -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX=../install ../.. plbrooks@LAPTOP-DEADBEEF MSYS /c/UserData/Programming/protobuf/cmake/build $ cmake --build . --target install # CMD: C:\UserData\Programming\protobuf\cmake\install\bin>protoc.exe --cpp_out=. --proto_path="C:/UserData/Programming/protobuf/examples/" addressbook.proto C: warning: directory does not exist. ``` Closes #21244 COPYBARA_INTEGRATE_REVIEW=#21244 from PierceLBrooks:plb/fix-protoc-absolute-path-arg-calls-outside-msys cde1231 PiperOrigin-RevId: 755406252
copybara-service
bot
force-pushed
the
test_754377153
branch
from
2625a67 to
c7730a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MSYS-built protoc CLI invokation cases where an arg is an absolute path (#21244)
Without these changes, if the
protocbinary is compiled from inside MSYS but gets invoked from the outside within the native Windowscmdshell environment, and one of the CLI arguments happens to be supplied as an absolute path string, then the*.pb.*code file generation process will fail with an error similar to the following sample output...Closes #21244
COPYBARA_INTEGRATE_REVIEW=#21244 from PierceLBrooks:plb/fix-protoc-absolute-path-arg-calls-outside-msys cde1231
FUTURE_COPYBARA_INTEGRATE_REVIEW=#21244 from PierceLBrooks:plb/fix-protoc-absolute-path-arg-calls-outside-msys cde1231