[ET-VK][Ops] choose_qparams.tensor test setup #11555

New issue

Jump to bottom

Merged

facebook-github-bot merged 11 commits into gh/ahmtox/20/base from gh/ahmtox/20/head

Jun 14, 2025

Contributor

ahmtox commented Jun 11, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: D76436894


          [ET-VK][Ops] choose_qparams.tensor test setup

e950186

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

ahmtox requested a review from SS-JIA as a code owner

June 11, 2025 16:59

pytorch-bot bot commented Jun 11, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11555

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Cancelled Job

As of commit 21a64d5 with merge base 8cfa858 ():

NEW FAILURES - The following jobs have failed:

Build Presets / linux (llm, linux.2xlarge, executorch-ubuntu-22.04-clang12) / build (gh)
Lint / link-check / lint-urls / linux-job (gh)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
Lint / lintrunner / linux-job (gh)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255

CANCELLED JOB - The following job was cancelled. Please retry:

Build documentation / build (buck2) / Build doc (gh)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jun 9, 2025

[ET] enabling half dtype input for quantization #11479

Merged

[ET-VK] double, short, and uint16 dtype runtime support #11365

Merged

[ET-VK][Ops] quantize ops skeleton test framework #11366

Merged

[ET-VK][Ops] quantize_per_token.default test setup #11367

Merged

[ET-VK][Ops] quantize_per_tensor.default test setup #11368

Merged

[ET-VK][Ops] quantization op shaders and impl #11369

Merged

[ET] enabling half dtype output for dequantization and making logic consistent #11552

Merged

[ET-VK][Ops] dequantize ops skeleton test framework #11480

Merged

[ET-VK][Ops] dequantize_per_tensor.default test setup #11481

Merged

[ET-VK][Ops] dequantize_per_token.default test setup #11482

Merged

[ET-VK][Ops] dequantization op shaders and impl #11483

Merged

[ET-VK][Ops] enabling double support for quantization and dequantization ops #11553

Merged

[ET-VK][Ops] choose_qparams ops skeleton test framework #11554

Merged

[ET-VK][Ops] choose_qparams_per_token_asymmetric.default test setup #11556

Merged

[ET-VK][Ops] choose_qparams op shaders and impl #11557

Merged

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Jun 11, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894

facebook-github-bot added the fb-exported label


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

f53c65c

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 11, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894

ahmtox added the release notes: vulkan label


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

9c79f64

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

ahmtox mentioned this pull request

[ET-VK][Ops] common test utils for converting aten types to vulkan types #11575

Merged

Contributor

facebook-github-bot commented Jun 11, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

5c463f6

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 12, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

3f6fc74

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 12, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

4d2f0c1

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 12, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

eed20e1

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 12, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894

SS-JIA approved these changes

View reviewed changes


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

63cdba8

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

06241c2

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

4c42d81

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894


          Update on "[ET-VK][Ops] choose_qparams.tensor test setup"

21a64d5

Creating choose_qparams.tensor operator testing framework along with a reference implementation for testing

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D76436894

facebook-github-bot merged commit b54acab into gh/ahmtox/20/base

92 of 98 checks passed

facebook-github-bot deleted the gh/ahmtox/20/head branch

June 14, 2025 03:47

facebook-github-bot temporarily deployed to cherry-pick-bot

June 14, 2025 03:47

— with

GitHub Actions Inactive

pytorchbot mentioned this pull request

[ET-VK][Ops] choose_qparams.tensor test setup #11679

Closed

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          [ET-VK][Ops] choose_qparams.tensor test setup

Pull Request resolved: pytorch/executorch#11555

# Context
In order to enhance my own understanding of these operators, I needed to create a reference implementation, and also build out the vulkan testing framework which creates the necessary build up when I need to call the vulkan implementations. I won't explain what the choose_qparams operator actually is in this diff, but will rather opt to explain the operator in a future diff where I implement the glsl shader, however, the reference implementation is heavily inspired by the cpu implementation.

This diff is the per_tensor reference implementation.

# Changes
The main changes were the include of the reference implementation that is used for my own learning, and the necessary wrapper functions that will be called later when the vulkan implementation is successfully completed. It has everything necessary for this purpose, including calling the operator by its appropriate name as when defined in the C++ implementation header, and staging components correctly from the GPU and then the CPU which will be where the comparison is done. I have also included comprehensive failure print statements that prints the tensor size along with relevant parameters.

This is for the per_tensor implementation.
ghstack-source-id: 290376482
@exported-using-ghexport

Differential Revision: [D76436894](https://our.internmc.facebook.com/intern/diff/D76436894/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported release notes: vulkan