[ExecuTorch][#10447] Extend PyBundledModule with extension.BundledModule
#11595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block pybinding backend migration Pull Request resolved: #11566 This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. ghstack-source-id: 289817083 Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/)
…Module` Pull Request resolved: #11565 # Context This issue is a step of #9638. In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`. # Proposal Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py ghstack-source-id: 289817714 ghstack-source-id: 289817714 @exported-using-ghexport Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
pytorchbot
requested review from
jathu,
larryliu0820,
kirklandsign,
JacobSzwejbka and
Gasoonjia
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11595
Note: Links to docs will display an error until the docs builds have been completed. ❌ 15 New Failures, 1 Unrelated FailureAs of commit d62f01f with merge base c4c4763 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
JacobSzwejbka
approved these changes
Jun 12, 2025
|
this is a bad pr that landed through internal flows. Theres a revert internally so im merging it here so that the revert can go through fine. Im not sure what happens if this never get merged and we only revert internally. It seems like it would likely cause a desync somewhere in the tooling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11565 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/13/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/13/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/14/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/13/orig
@diff-train-skip-merge