Hack/grafana mcp #6696
Merged
Hack/grafana mcp #6696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strip extra newlines
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
izaitsevfb
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
stamping to unblock, but as per our discussion, we still need to:
- extract components
- fix any types
- double-check (and probably simplify) the parsing
- remove dead code
but since this is an isolated change, we can merge it now and improve later (#6758)
|
(#6758) is not merged into this PR, so landing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the first version of /mcp_query, the Grafana dashboard creator. Linked to https://github.com/pytorch-labs/pytorch-gha-infra/pull/693 for the backend