Powershell-aware panic environment variable suggestions in backtraces… #99902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and grammatical consistency.
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
T-compiler
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
added
the
S-waiting-on-review
library/std/src/panicking.rs
Outdated
Comment on lines
300
to
309
| writeln!( | ||
| err, | ||
| "note: run with `$env:RUST_BACKTRACE=1` environment variable to display a backtrace." | ||
| ) | ||
| } else { | ||
| writeln!( | ||
| err, | ||
| "note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace." | ||
| ) | ||
| }; |
There was a problem hiding this comment.
Because .NET Core has made itself sufficiently cross-platform, my understanding is that for macOS, Linux, or Windows, we may be in PowerShell (and for all I know, PS runs on the BSDs too, with sufficient hackery). So we should not simply cfg this out if we accept this PR. And we can only know the value of this env var at runtime, which means we have to include these two strings both in the binary, and we have to make the branch.
While LLVM may successfully merge these strings into the same one, I think that if we accept this, we are probably better off splitting this write up (write!, then writeln!) and only writing "$env:" conditionally, with a fairly similar logic for the hint for using RUST_BACKTRACE="full". Which is valid syntax in a POSIX shell, by the way, so we can again reuse the same string.
There was a problem hiding this comment.
I feel like the strings are too tiny to have an actual real world effect on performance/binary size? Like, yes, you are correct and I agree that simply inserting "$env:" would be smaller. But it's barely anything in the first place 🤷🏻
There was a problem hiding this comment.
Well... I agree it's very little, but a very little is a lot if we're running on a machine with only MB, not GB, of RAM, one that nonetheless fits the Linux kernel and... probably someone's copy of the Almquist shell, they're usually lighter than bash. A lot of people in such cases complain about the weight of panic code, especially for uses where they're not interactively running the device and it's just a tiny server for some things.
On the other hand, maybe seeing too many requests on the Rust issue tracker to optimize out Literally Two Bytes from a binary has taken a toll on my sanity and I have finally Lost It. You decide.
There was a problem hiding this comment.
oof, sounds rough. Fair enough, tbh.
Will commit later 👍🏻
|
So, this might be a bit more complicated. The tests system for Rust will now need to support having a Powershell attribute, as if the developer hacking on Rust is using Powershell, the tests would fail. cc @jyn514 |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
The job Click to see the possible cause of the failure (guessed by this bot) |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and grammatical consistency.
This is forwarded from #98815 as I was having git problems. Sorry.