-
Notifications
You must be signed in to change notification settings - Fork 394
fix: vite config types #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: vite config types #1856
Conversation
now you'll get better type hints
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
More templates
commit: |
🦋 Changeset detectedLatest commit: 3366e73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
this also adds extensions to output .d.ts files so that projects with moduleResolution: "nodenext" can consume @solidjs/start, this doesn't change solid's moduleResolution. |
@atilafassina , is this Contrib CI check blocking because of the |
i think this was only here because bun didn't support brotli before. long ago bun added brotli support, so this is not needed.
also added brotli compression in bun |
now you'll get better type hints
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information