[5.x] Detect recursion when augmenting Entries #11854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnathonKoster
changed the title
JohnathonKoster
added a commit
to JohnathonKoster/cms
that referenced
this pull request
Jun 24, 2025
This reverts commit 6f2a5fb.
jasonvarga
pushed a commit
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds recursive augmentation detection. The current scope of this detection is Entries, but will apply to anything that utilizes
HasOrigin.This recursive behavior can be re-created when attempting to reference augmented values within computed callbacks (see #11853). This PR does not fix the underlying issue here, but makes it easier to detect and debug.