[5.x] Fix read-only state of roles and groups fields #11867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
user_rolesanduser_groupsfields in the user blueprint aren't displayed asread_onlyeven if a user doesn't have theassign rolesandassign user groupspermissions. This PR fixes that. It's only a UI fix, as theUsersControlleralready guards the fields from being updated without the appropriate permissions.Before:
After:
I actually went a step further and decided to hide the fields instead of making them read-only. I think this is more appropriate. Users without permission to change their role and group shouldn't be able to see those fields at all. It's just confusing.