Skip to content

initial implementation of blockhashjoin #19581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2025
Merged

initial implementation of blockhashjoin #19581

merged 3 commits into from
Jun 17, 2025

Conversation

lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented Jun 10, 2025 •
edited
Loading

Changelog entry

Added simple implementation of block hash join in dq. This implementation doesn't compute anything, only passes input blocks forward.
...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@lll-phill-lll lll-phill-lll requested review from a team as code owners June 10, 2025 19:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2025 •
edited
Loading

⚪ 2025-06-10 20:00:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1ac52a0 has started.
⚪ 2025-06-10 20:00:36 UTC Artifacts will be uploaded here
⚪ 2025-06-10 20:03:43 UTC ya make is running...
⚫ 2025-06-10 20:06:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2025 •
edited
Loading

🟢 2025-06-16 12:08:54 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2025 •
edited
Loading

⚪ 2025-06-10 20:02:46 UTC Pre-commit check linux-x86_64-release-asan for 1ac52a0 has started.
⚪ 2025-06-10 20:02:58 UTC Artifacts will be uploaded here
⚫ 2025-06-10 20:06:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2025 •
edited
Loading

⚪ 2025-06-10 20:11:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 44ebbbf has started.
⚪ 2025-06-10 20:11:37 UTC Artifacts will be uploaded here
🔴 2025-06-10 20:13:34 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2025 •
edited
Loading

⚪ 2025-06-10 20:11:26 UTC Pre-commit check linux-x86_64-release-asan for 44ebbbf has started.
⚪ 2025-06-10 20:11:37 UTC Artifacts will be uploaded here
🔴 2025-06-10 20:13:37 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 08:51:24 UTC Pre-commit check linux-x86_64-release-asan for 585dfa8 has started.
⚪ 2025-06-11 08:51:28 UTC Artifacts will be uploaded here
⚪ 2025-06-11 08:54:37 UTC ya make is running...
🔴 2025-06-11 08:58:16 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 08:51:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 585dfa8 has started.
⚪ 2025-06-11 08:51:33 UTC Artifacts will be uploaded here
⚪ 2025-06-11 08:54:40 UTC ya make is running...
🔴 2025-06-11 08:57:38 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 10:14:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 119639c has started.
⚪ 2025-06-11 10:14:30 UTC Artifacts will be uploaded here
⚪ 2025-06-11 10:17:42 UTC ya make is running...
🔴 2025-06-11 10:23:59 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 10:14:50 UTC Pre-commit check linux-x86_64-release-asan for 119639c has started.
⚪ 2025-06-11 10:15:25 UTC Artifacts will be uploaded here
⚪ 2025-06-11 10:18:38 UTC ya make is running...
🔴 2025-06-11 10:24:27 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 11:27:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5311ed7 has started.
⚪ 2025-06-16 11:27:35 UTC Artifacts will be uploaded here
⚪ 2025-06-16 11:31:20 UTC ya make is running...
⚫ 2025-06-16 12:04:05 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 11:27:32 UTC Pre-commit check linux-x86_64-release-asan for 5311ed7 has started.
⚪ 2025-06-16 11:27:36 UTC Artifacts will be uploaded here
⚪ 2025-06-16 11:30:52 UTC ya make is running...
⚫ 2025-06-16 12:04:04 UTC Check cancelled

@lll-phill-lll lll-phill-lll force-pushed the add-empty-block-hash-join branch from 221eee4 to 3869188 Compare June 16, 2025 12:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 12:05:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5d30cdb has started.
⚪ 2025-06-16 12:06:07 UTC Artifacts will be uploaded here
⚪ 2025-06-16 12:09:19 UTC ya make is running...
🟡 2025-06-16 13:26:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36076 33390 0 2 2658 26

⚪ 2025-06-16 13:29:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-16 13:40:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
431 (only retried tests) 410 0 0 0 21

🟢 2025-06-16 13:40:21 UTC Build successful.
🟡 2025-06-16 13:40:42 UTC ydbd size 2.2 GiB changed* by +519.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ad2f43f merge: 5d30cdb diff diff %
ydbd size 2 367 263 648 Bytes 2 367 796 040 Bytes +519.9 KiB +0.022%
ydbd stripped size 496 773 160 Bytes 496 837 224 Bytes +62.6 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 12:07:54 UTC Pre-commit check linux-x86_64-release-asan for 5d30cdb has started.
⚪ 2025-06-16 12:08:05 UTC Artifacts will be uploaded here
⚪ 2025-06-16 12:11:15 UTC ya make is running...
🟡 2025-06-16 13:57:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13912 13665 0 107 118 22

⚪ 2025-06-16 13:58:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-16 14:34:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1685 (only retried tests) 1543 0 58 64 20

⚪ 2025-06-16 14:34:22 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-16 15:08:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1437 (only retried tests) 1278 0 54 83 22

🟢 2025-06-16 15:08:24 UTC Build successful.
🟡 2025-06-16 15:08:56 UTC ydbd size 3.9 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ad2f43f merge: 5d30cdb diff diff %
ydbd size 4 163 911 448 Bytes 4 165 237 520 Bytes +1.3 MiB +0.032%
ydbd stripped size 1 445 078 296 Bytes 1 445 343 288 Bytes +258.8 KiB +0.018%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll linked an issue Jun 16, 2025 that may be closed by this pull request
Implement simple working DqBlockHashJoin #19691
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 17:14:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b0d387 has started.
⚪ 2025-06-16 17:14:12 UTC Artifacts will be uploaded here
🔴 2025-06-16 17:16:10 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 17:14:13 UTC Pre-commit check linux-x86_64-release-asan for 8b0d387 has started.
⚪ 2025-06-16 17:14:24 UTC Artifacts will be uploaded here
🔴 2025-06-16 17:16:25 UTC Graph compare failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 17:24:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0d43717 has started.
⚪ 2025-06-16 17:25:09 UTC Artifacts will be uploaded here
⚪ 2025-06-16 17:28:28 UTC ya make is running...
🔴 2025-06-16 17:31:21 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 17:25:12 UTC Pre-commit check linux-x86_64-release-asan for 0d43717 has started.
⚪ 2025-06-16 17:25:24 UTC Artifacts will be uploaded here
⚪ 2025-06-16 17:28:43 UTC ya make is running...
🔴 2025-06-16 17:32:14 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

⚪ 2025-06-17 11:54:48 UTC Pre-commit check linux-x86_64-release-asan for 7062218 has started.
⚫ 2025-06-17 11:55:52 UTC Check cancelled

@lll-phill-lll lll-phill-lll force-pushed the add-empty-block-hash-join branch from 8a80fd4 to b787fd8 Compare June 17, 2025 11:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

⚪ 2025-06-17 11:59:41 UTC Pre-commit check linux-x86_64-release-asan for bba9c14 has started.
⚪ 2025-06-17 11:59:52 UTC Artifacts will be uploaded here
⚪ 2025-06-17 12:03:08 UTC ya make is running...
🟡 2025-06-17 13:40:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13889 13708 0 81 77 23

⚪ 2025-06-17 13:41:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-17 14:16:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1754 (only retried tests) 1574 0 60 98 22

⚪ 2025-06-17 14:17:10 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-17 14:50:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1371 (only retried tests) 1221 0 60 68 22

🟢 2025-06-17 14:51:07 UTC Build successful.
🟢 2025-06-17 14:51:41 UTC ydbd size 3.9 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a9dc387 merge: bba9c14 diff diff %
ydbd size 4 172 478 144 Bytes 4 172 494 184 Bytes +15.7 KiB +0.000%
ydbd stripped size 1 446 920 568 Bytes 1 446 927 224 Bytes +6.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

⚪ 2025-06-17 12:00:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for bba9c14 has started.
⚪ 2025-06-17 12:00:42 UTC Artifacts will be uploaded here
⚪ 2025-06-17 12:04:06 UTC ya make is running...
🟡 2025-06-17 13:24:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36097 33381 0 7 2663 46

⚪ 2025-06-17 13:27:14 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-17 13:38:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
612 (only retried tests) 588 0 0 0 24

🟢 2025-06-17 13:39:10 UTC Build successful.
🟡 2025-06-17 13:39:30 UTC ydbd size 2.2 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7eb7f65 merge: bba9c14 diff diff %
ydbd size 2 371 138 248 Bytes 2 372 216 768 Bytes +1.0 MiB +0.045%
ydbd stripped size 497 369 576 Bytes 497 399 336 Bytes +29.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll enabled auto-merge (squash) June 17, 2025 14:48
@lll-phill-lll lll-phill-lll merged commit 63c2e1f into ydb-platform:main Jun 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzuev pzuev

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement simple working DqBlockHashJoin
2 participants
@lll-phill-lll @pzuev