Skip to content

Fix intersections in visualize_portions #19589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Fix intersections in visualize_portions #19589

merged 1 commit into from
Jun 16, 2025

Conversation

snaury
Copy link
Member

@snaury snaury commented Jun 11, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Don't draw zero-height rectangles when there are no intersections, and handle cases like portions [a, b] and [b, c] intersecting at point b.

@snaury snaury self-assigned this Jun 11, 2025
@snaury snaury marked this pull request as ready for review June 11, 2025 09:17
@snaury snaury requested a review from a team as a code owner June 11, 2025 09:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 09:17:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8c26ef5 has started.
⚪ 2025-06-11 09:17:44 UTC Artifacts will be uploaded here
⚪ 2025-06-11 09:20:10 UTC ya make is running...
🟢 2025-06-11 09:20:50 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4 4 0 0 0 0

🟢 2025-06-11 09:20:56 UTC Build successful.

@github-actions GitHub Actions
Copy link

🟢 2025-06-11 09:20:05 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 09:20:49 UTC Pre-commit check linux-x86_64-release-asan for 8c26ef5 has started.
⚪ 2025-06-11 09:21:02 UTC Artifacts will be uploaded here
⚪ 2025-06-11 09:23:28 UTC ya make is running...
🟢 2025-06-11 09:24:06 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 2 0 0 0 0

🟢 2025-06-11 09:24:12 UTC Build successful.

@snaury snaury enabled auto-merge (squash) June 11, 2025 15:26
@snaury snaury force-pushed the fix-cs-intersection-graph branch from e29fe66 to 95b8ec3 Compare June 11, 2025 15:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 15:56:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for d59a5d7 has started.
⚪ 2025-06-11 15:56:35 UTC Artifacts will be uploaded here
⚪ 2025-06-11 15:59:04 UTC ya make is running...
🟡 2025-06-11 16:00:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4 3 0 1 0 0

⚪ 2025-06-11 16:00:10 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-11 16:00:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

⚪ 2025-06-11 16:00:48 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-06-11 16:01:36 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

🟢 2025-06-11 16:01:42 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 15:57:59 UTC Pre-commit check linux-x86_64-release-asan for d59a5d7 has started.
⚪ 2025-06-11 15:58:10 UTC Artifacts will be uploaded here
⚪ 2025-06-11 16:00:32 UTC ya make is running...
🟡 2025-06-11 16:01:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 1 0 1 0 0

⚪ 2025-06-11 16:01:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-11 16:02:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

⚪ 2025-06-11 16:02:40 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-11 16:03:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

🟢 2025-06-11 16:03:13 UTC Build successful.

zverevgeny
zverevgeny previously approved these changes Jun 13, 2025
View reviewed changes
@snaury snaury force-pushed the fix-cs-intersection-graph branch from 95b8ec3 to 86a0d64 Compare June 16, 2025 07:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 07:12:25 UTC Pre-commit check linux-x86_64-release-asan for b85fd06 has started.
⚪ 2025-06-16 07:12:50 UTC Artifacts will be uploaded here
⚪ 2025-06-16 07:15:09 UTC ya make is running...
🟢 2025-06-16 07:15:42 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 2 0 0 0 0

🟢 2025-06-16 07:15:49 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 07:14:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for b85fd06 has started.
⚪ 2025-06-16 07:14:24 UTC Artifacts will be uploaded here
⚪ 2025-06-16 07:16:53 UTC ya make is running...
🟢 2025-06-16 07:17:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4 4 0 0 0 0

🟢 2025-06-16 07:17:37 UTC Build successful.

@snaury snaury merged commit a96d0ba into ydb-platform:main Jun 16, 2025
12 checks passed
@snaury snaury deleted the fix-cs-intersection-graph branch June 16, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny

Assignees

@snaury snaury

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaury @zverevgeny