Skip to content

Support bridge mode for BSC storage pools #19598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Support bridge mode for BSC storage pools #19598

merged 1 commit into from
Jun 17, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jun 11, 2025

Changelog entry

Support bridge mode for BSC storage pools

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This patch allows BSC managing bridged mode groups automatically. User still see pools as they expected them to see.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 11:33:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0aa8daf has started.
⚪ 2025-06-11 11:34:04 UTC Artifacts will be uploaded here
⚪ 2025-06-11 11:37:45 UTC ya make is running...
🔴 2025-06-11 12:01:54 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

🟢 2025-06-11 11:37:43 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 11:42:02 UTC Pre-commit check linux-x86_64-release-asan for 0aa8daf has started.
⚪ 2025-06-11 11:42:08 UTC Artifacts will be uploaded here
⚪ 2025-06-11 11:45:22 UTC ya make is running...
🔴 2025-06-11 11:58:15 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the 2dc/bsc-pools-for-bridge-mode branch from 1930abb to f1f0417 Compare June 11, 2025 14:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

⚪ 2025-06-11 14:27:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6829643 has started.
⚪ 2025-06-11 14:27:23 UTC Artifacts will be uploaded here
⚪ 2025-06-11 14:31:22 UTC ya make is running...
🔴 2025-06-11 14:45:53 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the 2dc/bsc-pools-for-bridge-mode branch from f1f0417 to 2a37107 Compare June 16, 2025 12:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 12:16:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for a63b3de has started.
⚪ 2025-06-16 12:16:15 UTC Artifacts will be uploaded here
⚪ 2025-06-16 12:19:43 UTC ya make is running...
🟡 2025-06-16 13:39:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37809 35099 0 16 2660 34

⚪ 2025-06-16 13:43:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-16 13:55:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
602 (only retried tests) 564 0 13 0 25

⚪ 2025-06-16 13:55:23 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-06-16 14:05:53 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
456 (only retried tests) 423 0 12 0 21

🟢 2025-06-16 14:06:04 UTC Build successful.
🟡 2025-06-16 14:06:28 UTC ydbd size 2.2 GiB changed* by +846.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ad2f43f merge: a63b3de diff diff %
ydbd size 2 367 263 648 Bytes 2 368 130 416 Bytes +846.5 KiB +0.037%
ydbd stripped size 496 773 160 Bytes 496 856 456 Bytes +81.3 KiB +0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 12:17:45 UTC Pre-commit check linux-x86_64-release-asan for a63b3de has started.
⚪ 2025-06-16 12:18:04 UTC Artifacts will be uploaded here
⚪ 2025-06-16 12:21:28 UTC ya make is running...
🔴 2025-06-16 12:29:35 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the 2dc/bsc-pools-for-bridge-mode branch from 2a37107 to f126e00 Compare June 16, 2025 15:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 15:30:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 42b821d has started.
⚪ 2025-06-16 15:30:21 UTC Artifacts will be uploaded here
⚪ 2025-06-16 15:33:39 UTC ya make is running...
⚫ 2025-06-16 16:11:31 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 15:30:26 UTC Pre-commit check linux-x86_64-release-asan for 42b821d has started.
⚪ 2025-06-16 15:30:37 UTC Artifacts will be uploaded here
⚪ 2025-06-16 15:33:53 UTC ya make is running...
🔴 2025-06-16 15:40:06 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the 2dc/bsc-pools-for-bridge-mode branch from f126e00 to 5ead754 Compare June 16, 2025 16:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 16:15:46 UTC Pre-commit check linux-x86_64-release-asan for 569ba23 has started.
⚪ 2025-06-16 16:15:51 UTC Artifacts will be uploaded here
⚪ 2025-06-16 16:19:18 UTC ya make is running...
🟡 2025-06-16 18:03:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15626 15400 0 126 80 20

⚪ 2025-06-16 18:04:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-16 18:39:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2205 (only retried tests) 2020 0 73 93 19

⚪ 2025-06-16 18:39:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-16 19:12:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1684 (only retried tests) 1550 0 56 61 17

🟢 2025-06-16 19:13:13 UTC Build successful.
🟡 2025-06-16 19:13:44 UTC ydbd size 3.9 GiB changed* by +425.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fc67d74 merge: 569ba23 diff diff %
ydbd size 4 165 394 712 Bytes 4 165 830 568 Bytes +425.6 KiB +0.010%
ydbd stripped size 1 445 399 992 Bytes 1 445 459 960 Bytes +58.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 16:16:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 569ba23 has started.
⚪ 2025-06-16 16:16:42 UTC Artifacts will be uploaded here
⚪ 2025-06-16 16:20:00 UTC ya make is running...
🟡 2025-06-16 17:38:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37839 35136 0 7 2663 33

⚪ 2025-06-16 17:42:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-16 17:55:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
699 (only retried tests) 670 0 0 0 29

🟢 2025-06-16 17:55:20 UTC Build successful.
🟡 2025-06-16 17:55:41 UTC ydbd size 2.2 GiB changed* by +325.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fc67d74 merge: 569ba23 diff diff %
ydbd size 2 367 897 776 Bytes 2 368 230 760 Bytes +325.2 KiB +0.014%
ydbd stripped size 496 863 112 Bytes 496 881 576 Bytes +18.0 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) June 16, 2025 19:21
@alexvru alexvru merged commit 9db6f09 into ydb-platform:main Jun 17, 2025
11 checks passed
@alexvru alexvru deleted the 2dc/bsc-pools-for-bridge-mode branch June 17, 2025 06:25
@alexvru alexvru self-assigned this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruall kruall

Assignees

@alexvru alexvru

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexvru @kruall