Skip to content

Fix ftxui build in windows #19626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Fix ftxui build in windows #19626

merged 1 commit into from
Jun 16, 2025

Conversation

eivanov89
Copy link
Member

@eivanov89 eivanov89 commented Jun 12, 2025 •
edited by pnv1
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

It's a temporary solution to build a YDB CLI release. The same changes will be made in arcadia and synced here later.

@eivanov89 eivanov89 requested a review from a team as a code owner June 12, 2025 06:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2025 •
edited
Loading

⚪ 2025-06-12 06:37:18 UTC Pre-commit check linux-x86_64-release-asan for 9249b7f has started.
⚪ 2025-06-12 06:37:44 UTC Artifacts will be uploaded here
⚪ 2025-06-12 06:40:12 UTC ya make is running...
🟢 2025-06-12 06:40:18 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-12 06:40:24 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2025 •
edited
Loading

🟢 2025-06-16 18:18:54 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2025 •
edited
Loading

⚪ 2025-06-12 06:38:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9249b7f has started.
⚪ 2025-06-12 06:38:36 UTC Artifacts will be uploaded here
⚪ 2025-06-12 06:41:06 UTC ya make is running...
🟢 2025-06-12 06:41:11 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-12 06:41:17 UTC Build successful.

@eivanov89 eivanov89 enabled auto-merge (squash) June 12, 2025 09:28
maximyurchuk
maximyurchuk requested changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@maximyurchuk maximyurchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот сорец, это зеркало, правильно править в Аркадии

@eivanov89 eivanov89 closed this Jun 16, 2025
auto-merge was automatically disabled June 16, 2025 10:16

Pull request was closed

@pnv1 pnv1 reopened this Jun 16, 2025
@pnv1
Copy link
Collaborator

pnv1 commented Jun 16, 2025

It's a temporary solution to build a YDB CLI release. The same changes will be made in arcadia and synced here later.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 18:14:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3670f58 has started.
⚪ 2025-06-16 18:15:40 UTC Artifacts will be uploaded here
⚪ 2025-06-16 18:18:35 UTC ya make is running...
🟢 2025-06-16 18:18:40 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-16 18:18:46 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 16, 2025 •
edited
Loading

⚪ 2025-06-16 18:16:16 UTC Pre-commit check linux-x86_64-release-asan for 3670f58 has started.
⚪ 2025-06-16 18:16:27 UTC Artifacts will be uploaded here
⚪ 2025-06-16 18:18:54 UTC ya make is running...
🟢 2025-06-16 18:18:59 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-16 18:19:05 UTC Build successful.

@eivanov89 eivanov89 enabled auto-merge (squash) June 16, 2025 18:18
maximyurchuk
maximyurchuk approved these changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@maximyurchuk maximyurchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

После релиза CLI прошу оперативно откатить. Как временное решение для релиза -- норм

@eivanov89 eivanov89 merged commit 05632d8 into ydb-platform:main Jun 16, 2025
22 checks passed
@eivanov89 eivanov89 deleted the fix_win_build2 branch June 16, 2025 20:10
eivanov89 added a commit to eivanov89/ydb that referenced this pull request Jun 17, 2025
@eivanov89
Revert "Fix ftxui build in windows (ydb-platform#19626)"
e8efebe 
This reverts commit 05632d8.
eivanov89 added a commit that referenced this pull request Jun 17, 2025
@eivanov89
Revert "Fix ftxui build in windows (#17333, #19626)" (#19716)
196d2a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnv1 pnv1

@maximyurchuk maximyurchuk

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eivanov89 @pnv1 @maximyurchuk