bugfix: allow DinD image to be configured via values #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the DinD image configurable by checking the container spec for a container named "dind" and using its defined image if present. Defaults to "docker:dind" otherwise.
yashrajdighe
requested review from
mumoshu,
toast-gear,
nikola-jokic,
rentziass and
a team
as code owners
yashrajdighe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
DinDimage to be configured via Helm values by checking the container spec for a container nameddindand using the defined image if present. If no custom image is specified, it defaults todocker:dind.This change is necessary because we're hitting Docker Hub rate limits when pulling the default DinD image. By making the image configurable, we can use a custom image from our own registry, which helps avoid these limitations and improves reliability in CI workflows.
The change is already tested in the cloned chart and is working as expected.