Cleanup feature flag actions_skip_retry_complete_job_upon_known_errors

[ericsciple]

Related PR:

• Do not retry CompleteJobAsync for known non-retryable errors #3696

[Copilot]

Pull Request Overview

This PR removes legacy feature flag support for "actions_skip_retry_complete_job_upon_known_errors" to simplify job completion logic. Key changes include:

• Removing the conditional branch that calls CompleteJob2Async and its associated catch filters in JobRunner.cs.
• Eliminating the CompleteJob2Async method from the RunServer interface in RunServer.cs.
• Deleting the SkipRetryCompleteJobUponKnownErrors constant from Constants.cs.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/Runner.Worker/JobRunner.cs	Removed conditional logic based on the feature flag and updated exception handling.
src/Runner.Common/RunServer.cs	Removed legacy CompleteJob2Async method and related implementation.
src/Runner.Common/Constants.cs	Removed the deprecated feature flag constant.

Comments suppressed due to low confidence (2)

src/Runner.Common/RunServer.cs:32

• Ensure that all references to 'CompleteJob2Async' have been completely removed after deprecation to avoid any unintentional calls or interface mismatches in the future.

Task CompleteJob2Async(

src/Runner.Worker/JobRunner.cs:324

• The removal of the feature flag check in the catch block changes the exception handling behavior. Please confirm that this uniform approach to handling VssUnauthorizedException is intentional and does not hide side effects previously gated by the flag.

catch (VssUnauthorizedException ex)