-
Notifications
You must be signed in to change notification settings - Fork 530
ci: switch to custom setup-go action in windows #15623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
tested on my fork, test windows time went down from ~5m to ~1m: https://github.com/kruskall/apm-server/actions/runs/13245308706/job/36972215506 |
@@ -45,7 +45,13 @@ jobs: | |||
runs-on: ${{ matrix.os }} | |||
steps: | |||
- uses: actions/checkout@v4 | |||
- uses: antontroshin/setup-go@bda02de8887c9946189f81e7e59512914aeb9ea4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To play safe, this is a fork commit, and somehow I feel we could raise the fix to the upstream maybe, instead of using the fork from someone else.
I understand the benefits, but I'm a bit concerned about opening this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OTOH, we are using permissions: contents: read
by default. But according to our guideline, we need to be cautious to use third-party actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's already a PR open for it upstream, the action is from that PR 😭
OTOH, we are using permissions: contents: read by default. But according to our guideline, we need to be cautious to use third-party actions.
fully agree with this. I pinned the action to a commit to avoid tampering. It should be enough to avoid such issues. WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can give a go; the only thing could be the one whether the commit vanished
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8)
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8)
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8)
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8)
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8)
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8) # Conflicts: # .github/workflows/ci.yml
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8) Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8) Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
* ci: update GOCACHE vars on windows runner to improve performance windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time * Update ci.yml (cherry picked from commit 211ccc8) Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
Motivation/summary
windows runner has significantly slower disks and restoring the cache is wasting a huge amount of time
Checklist
For functional changes, consider:
How to test these changes
Related issues
See actions/setup-go#495
Slightly related to #15581