Skip to content

ci: fix golangci-lint using go toolchain version in pre-commit #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

lukasmetzner
Copy link
Contributor

Fixes pre-commit CI pipeline of #881.

@lukasmetzner lukasmetzner requested a review from a team as a code owner March 11, 2025 07:59
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (2322869) to head (a2925bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files          31       31           
  Lines        3343     3343           
=======================================
  Hits         2360     2360           
  Misses        804      804           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the version is the one before the jump to go1.24.

@lukasmetzner
Copy link
Contributor Author

I assume the version is the one before the jump to go1.24.

It corresponds to the current toolchain version in main.

@lukasmetzner lukasmetzner merged commit 46564d5 into main Mar 11, 2025
9 checks passed
@lukasmetzner lukasmetzner deleted the ci-fix-golangci-lint-go-version branch March 11, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants