Skip to content

Update shadow jar plugin, and code cleanup #5246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Omico
Copy link
Contributor

@Omico Omico commented Feb 26, 2025

Please review each commit message for the details.

@MatkovIvan MatkovIvan requested a review from igordmn February 27, 2025 09:39
Bigray2025

This comment was marked as off-topic.

Omico added 6 commits July 7, 2025 22:50
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combining cleanups and introducing new public API is not good idea.

PS I've assigned right people as reviewers

@MatkovIvan MatkovIvan requested a review from terrakok July 7, 2025 15:22
@terrakok
Copy link
Member

terrakok commented Jul 7, 2025

Could you explain your motivation for refactorings and version updates?
I don't see a reason for that at all. Yes, might be it is not perfect but there is no reasons to change it right now.

@Omico Omico changed the title Add ui-backhandler dependency to compose dependencies, update shadow jar plugin, and code cleanup Update shadow jar plugin, and code cleanup Jul 7, 2025
@Omico
Copy link
Contributor Author

Omico commented Jul 7, 2025

Could you explain your motivation for refactorings and version updates? I don't see a reason for that at all. Yes, might be it is not perfect but there is no reasons to change it right now.

Just general code cleanup, I can revert it if you unhappy with that.

For our current Dependencies class, honestly I want to let it inherit org.gradle.api.plugins.ExtensionAware therefore we can enable the ability to let user do some customization. Thought this we can declare dependencies dynamically via Gradle API. What do you think of this idea? Here is an example that I'm using below:
image
image
image

image
https://github.com/Omico/picsum/blob/96cbfe231420c4951740313058962e252874dfb5/picsum/kami/kotlin-multiplatform-library/build.gradle.kts#L24-L37

image
https://github.com/Omico/picsum/blob/96cbfe231420c4951740313058962e252874dfb5/picsum/kami/android-application/build.gradle.kts#L23-L28

kami & kamiDependenciesexist to avoid potential naming restrictions of Gradle.

Also, the code above is generable via Kotlinpoet, but I don't have time to implement it because I have a full-time job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants