-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update shadow jar plugin, and code cleanup #5246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposePlugin.kt
Outdated
Show resolved
Hide resolved
…L and correct license url
Test.systemProperties() marked as EXTENSION_SHADOWED_BY_MEMBER
Since ComposeBuildConfig.composeVersion is a static Sting and its parent is an object class we don't need to use get or lazy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combining cleanups and introducing new public API is not good idea.
PS I've assigned right people as reviewers
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposePlugin.kt
Outdated
Show resolved
Hide resolved
Could you explain your motivation for refactorings and version updates? |
Just general code cleanup, I can revert it if you unhappy with that. For our current
Also, the code above is generable via Kotlinpoet, but I don't have time to implement it because I have a full-time job. |
Please review each commit message for the details.