-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(grpc): Fix error "proto3 disallow 'optional' label" #14426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
When grpc-gateway plugin loads a proto3 proto file with optional labeled fields, it will throw an error "proto3 disallow 'optional' label". This fixes the issue by enabling proto3_optional in protoc.
With 1 more approval I will add change log for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution! 🚀
@StarlightIbuki PR now has 2 approvals. Could you add change log please? |
@yixinguo-ssc I don't have write access to your branch. You could add a changelog file to message: Fixed an issue where gRPC plugins lack support for "optional".
scope: Plugins
type: bugfix |
Summary
Fix Issue 14421
grpc-gateway fails to load proto file with message "proto3 disallow 'optional' label"
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[14421](#14421)