-
Notifications
You must be signed in to change notification settings - Fork 533
Rename /extensions-chromium/ to /extensions/ #3483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehoffms
commented
Jun 19, 2025
This was referenced Jun 19, 2025
mikehoffms
commented
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Writer/Editor
captainbrosset
approved these changes
Jun 24, 2025
Learn Build status updates of commit 43e2ed9: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR to merge after the present PR or 5 PRs:
microsoft/MicrosoftEdge-Extensions#317
Rendered articles for review:
/extensions/developer-guide/sidebar.md
/extensions-chromium/
to/extensions/
Redirects to test before Merge:
Construction of the test links
Every
source_path
in the revised Redirects file, converted toreview.LMC
url for the PR, is listed below, to test.Impl. of 1st redir:
The "View" url in build report:
https://review.learn.microsoft.com/en-us/microsoft-edge/extensions/developer-guide/declare-permissions?branch=pr-en-us-3483
The [View] link matches
redirect_url
, which is not what we want to test.Below, constructed instead the url for each
source_path
.The static parts of the [View] url to use:
https://review.learn.microsoft.com/microsoft-edge/__?branch=pr-en-us-3483
Inserting the non-static portion from
source_path
:https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/enterprise/declare-permissions?branch=pr-en-us-3483
Older entries
This PR re-sequences these old entries, per the TOC design, to group entries that point to same URL, in order to avoid chaining two entries.
Chaining involves use of an outdated, non-existing filepath, hard to maintain.
All destination URLs (in old Extensions redirects) have been updated, to avoid chaining.
Latest TOC
One .yml at top, impl:
Two external Legal toc entries here, not shown, n/a.
Planning: AB#54220680
PR tracking: AB#58047194