Skip to content

Draft: Add support for rule executable_jar #7783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joca-bt
Copy link
Contributor

@joca-bt joca-bt commented Jul 5, 2025

I'm trying to add support for the executable_jar rule. While these changes add support for debugging from BUILD files, the gutter on source files doesn't recognize the target.

image

Would you be so kind to point me in the right direction to add this functionality?

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

@LeFrosch
Copy link
Collaborator

LeFrosch commented Jul 7, 2025

Hey, thanks for the PR. @jastice do you want to proceed with this PR? The rule set is listed on the BCR: https://registry.bazel.build/modules/extra_rules_java

@jastice
Copy link
Collaborator

jastice commented Jul 7, 2025

Hi @joca-bt, from my side it's good to merge, but I would recommend contributing to the new Bazel plugin by JetBrains at https://github.com/JetBrains/hirschgarten/ instead, as we're going to discontinue support for this one roughly by end of the year.

@jastice jastice self-requested a review July 7, 2025 07:27
@LeFrosch
Copy link
Collaborator

LeFrosch commented Jul 7, 2025

Judging by the code, this is not enough to fully support your rule set, or is it? @joca-bt

@joca-bt
Copy link
Contributor Author

joca-bt commented Jul 7, 2025

Hello @LeFrosch, it's not. My changes make the rule available in BUILD files and I can debug from there, but in source files the gutter context is not working as I wrote in my initial message above. Could you point me in the right direction to fix that?

@jastice we are still using this plugin, so we'd like to make it available first in this one. Once the other exits EAP we will integrate with that one.

@jastice
Copy link
Collaborator

jastice commented Jul 7, 2025

we are still using this plugin, so we'd like to make it available first in this one. Once the other exits EAP we will integrate with that one.

We are going to announce GA this month :)

@joca-bt
Copy link
Contributor Author

joca-bt commented Jul 12, 2025

@jastice can you provide some pointers on where to start for hirschgarten for these changes? It shows such targets as runnable by default, however it doesn't show the debug option for such targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Awaiting review from Bazel team on PRs product: IntelliJ IntelliJ plugin
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

4 participants