feat: update github adapter spec #1306
Conversation
Signed-off-by: Remi Cattiau <remi@cattiau.com>
Signed-off-by: Remi Cattiau <remi@cattiau.com>
Signed-off-by: Remi Cattiau <remi@cattiau.com>
Signed-off-by: Remi Cattiau <remi@cattiau.com>
Signed-off-by: Remi Cattiau <remi@cattiau.com>
Signed-off-by: Remi Cattiau <remi@cattiau.com>
Signed-off-by: Remi Cattiau <remi@cattiau.com>
| | `datacontentencoding` | Omit | | ||
| | `datacontenttype` | `application/json` | | ||
| | `dataschema` | Omit | | ||
| | `subject` | "repository.name" value | |
There was a problem hiding this comment.
The id is really not that useful to filter on
| | `datacontentencoding` | Omit | | ||
| | `datacontenttype` | `application/json` | | ||
| | `dataschema` | Omit | | ||
| | `subject` | Omit | |
There was a problem hiding this comment.
Same as first comment, we have the repository url in source, not sure we need the id in subject
| | `datacontentencoding` | Omit | | ||
| | `datacontenttype` | `application/json` | | ||
| | `dataschema` | Omit | | ||
| | `subject` | "workflow_job.name" value | |
There was a problem hiding this comment.
I wonder if workflow_job.id is better in the case of a rename?
There was a problem hiding this comment.
Most of GH ui only show the name, so my assumption is name would be more useful.
I do not know if the id change or not on rename
There was a problem hiding this comment.
what about workflow_job.run_url?
There was a problem hiding this comment.
So run_url bring you to a page that does not even contain the info of the job, the url which is different from run_url can be derived from the id but as I dont think you can really predict the id, it seems to me like a bit fastidious to filter on. My initial guess is we want to have valuable information to ease filtering.
For example it is likely i will want to target a specific workflow name in a specific repository so filtering on both source and a startsWith on subject
| | `datacontentencoding` | Omit | | ||
| | `datacontenttype` | `application/json` | | ||
| | `dataschema` | Omit | | ||
| | `subject` | "workflow.name" value | |
There was a problem hiding this comment.
I can't figure out of "name" need to be unique or not. I'm assuming 'id' must be.
From co-pilot:
the name field in a GitHub workflow does not need to be unique. The name is used for display purposes and helps you identify the workflow in the GitHub Actions tab
There was a problem hiding this comment.
actually, should this be the workflow.url ?
|
@loopingz any update on this? |
|
Conditionally approved on the 8/29 call - once the open comments are closed |
|
This Pull Request is stale because it has been open for 30 days with |
|
@loopingz did you want to reply to the open comments? |
|
This Pull Request is stale because it has been open for 30 days with |
|
ping @loopingz |
|
This Pull Request is stale because it has been open for 30 days with |
|
@loopingz any chance of getting the updates to this one done in time for next week's call? |
|
@loopingz do you think we can try to wrap this one up by next week's call? |
Signed-off-by: Remi Cattiau <remi@cattiau.com>
Proposed Changes