Skip to content

feat: VertexAI keyFile, keyJson, and express/apiKey support #6526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jul 9, 2025

Description

Adds support for additional authentication methods for VertexAI

  • Path to keys json file using env.keyFile (YAML only)
  • Inline keys json using env.keyJson (YAML only)
  • Express mode using apiKey (JSON and YAML)

Adds docs for the express mode case.
TODO add docs for keyFile and keyJson methods


Summary by cubic

Added support for VertexAI Express mode, allowing users to authenticate with an API key instead of Google Cloud credentials. Updated documentation with setup instructions and examples.

  • New Features
    • Accepts apiKey for Gemini models using Express mode.
    • Ignores region and projectId when apiKey is provided.
    • Added docs with YAML and JSON config examples for Express mode.

@RomneyDa RomneyDa requested a review from a team as a code owner July 9, 2025 00:28
@RomneyDa RomneyDa requested review from sestinj and removed request for a team July 9, 2025 00:28
Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 0267885
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/686e1edde8a00f0008c6a022

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

⚠️ Conventional Commit Format

Your commit messages don't follow the conventional commit format, but this won't block your PR from being merged. We recommend downloading this extension if you are using VS Code.

Expected Format:

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 1 issue across 2 files. Review it in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

@RomneyDa RomneyDa changed the title feat: VertexAI Express Mode/API key support feat: VertexAI keyFile, keyJson, and express/apiKey support Jul 9, 2025
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomneyDa I really really really don't like that this is all inlined in the constructor, but gotta get this out. so can refactor later

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 10, 2025
@sestinj sestinj merged commit 9de7e58 into main Jul 10, 2025
78 of 80 checks passed
@sestinj sestinj deleted the dallin/vertex-openai-adapter branch July 10, 2025 01:53
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants