Skip to content

Revert "chore: terminate all tasks after debug" #6539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Jul 9, 2025

Reverts #6405

This is causing an issue where every time you reload the debug window, all the processes are terminated.


Summary by cubic

Removed automatic termination of all tasks after debugging to prevent processes from being killed when reloading the debug window.

@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner July 9, 2025 21:58
@Patrick-Erichsen Patrick-Erichsen requested review from RomneyDa and removed request for a team July 9, 2025 21:58
Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 92d1df2
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/686ee612061f2b0008d56389

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 9, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed this PR and found no issues. Review PR in cubic.dev.

@Patrick-Erichsen
Copy link
Collaborator Author

@uinstinct reverting the commit for now, but it would still be nice to have the original feature that you were trying to do here, so might be worth a second shot!

FWIW, here's what Claude 4 had to say about the issue, seems like it might not be possible if this is true:

The problem is that the postDebugTask is set to "Terminate All Tasks" which terminates all tasks when the debug session ends. However, when you reload the debug window (as opposed to fully stopping it), VS Code is treating this as the debug session ending and triggering the postDebugTask.

Let me check if there's a way to distinguish between a reload and a full stop in VS Code's debug configuration, or if we need to modify the approach.

Looking at the current configuration:

The postDebugTask is set to "Terminate All Tasks"
The "Terminate All Tasks" task uses workbench.action.tasks.terminate with terminateAll argument
This terminates ALL tasks, but apparently one task (npm run esbuild-notify) survives
The issue is that VS Code doesn't distinguish between a reload and a stop when it comes to postDebugTask. Both actions trigger the post-debug task.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 9, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2025
@RomneyDa RomneyDa merged commit 3f498fa into main Jul 10, 2025
80 of 82 checks passed
@RomneyDa RomneyDa deleted the revert-6405-chore-terminate-tasks branch July 10, 2025 00:48
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants