-
Notifications
You must be signed in to change notification settings - Fork 214
switch to grpc-netty-shaded #21470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
switch to grpc-netty-shaded #21470
Conversation
What's the motivation for this? Do we have any conflict at the moment or is this a quality of life improvement? Also do we know how big is the grpc-netty-shaded compared to grpc-netty? |
2d873ed
to
38a290b
Compare
This switches to grpc-netty-shaded is a proactive quality of life improvement to prevent dependency conflicts. It isolates the version of Netty that gRPC uses, avoiding potential clashes with other versions that might exist on the classpath. This prevents hard-to-debug runtime issues. Concerning the size, we're swapping a group of smaller Netty jars for a single, larger, self-contained one, so they should no impact. |
Not for us, but it has an impact for those users that use Netty, as they now need to download it twice. |
You're right, this will impact clients that use Netty directly together with our gRPC libraries or the Java code generated. Together with @rgugliel-da and @soren-da, we judged this trade-off was acceptable. The decision was based on two key factors:
|
following [official recommendation](https://github.com/grpc/grpc-java/blob/master/SECURITY.md#netty)
38a290b
to
8d488d1
Compare
following official recommendation