-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Expose HTTP connection metrics to telemetry #130939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose HTTP connection metrics to telemetry #130939
Conversation
Closes ES-12223
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Hi @DaveCTurner, I've created a changelog YAML for you. |
Do you know which thread runs channel initializer? Is it same stack that accepts socket? I'm wondering for case when transport threads are saturated and we accept new socket but haven't setup channel pipeline yet, so these metrics wont reflect that. Should we measure those on parent channel that listen socket? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor question about place for metrics capturing.
No, the channel is initialized on its own event loop, see |
Closes ES-12223