Skip to content

Expose HTTP connection metrics to telemetry #130939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DaveCTurner
Copy link
Contributor

Closes ES-12223

@DaveCTurner DaveCTurner requested a review from mhl-b July 9, 2025 16:37
@DaveCTurner DaveCTurner added >enhancement :Distributed Coordination/Network Http and internode communication implementations v9.2.0 labels Jul 9, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Jul 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@mhl-b
Copy link
Contributor

mhl-b commented Jul 9, 2025

Do you know which thread runs channel initializer? Is it same stack that accepts socket?

I'm wondering for case when transport threads are saturated and we accept new socket but haven't setup channel pipeline yet, so these metrics wont reflect that. Should we measure those on parent channel that listen socket?

Copy link
Contributor

@mhl-b mhl-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor question about place for metrics capturing.

@DaveCTurner
Copy link
Contributor Author

Do you know which thread runs channel initializer? Is it same stack that accepts socket?

No, the channel is initialized on its own event loop, see io.netty.channel.AbstractChannel.AbstractUnsafe#register. I don't think that matters very much for these stats: if the event loop is saturated then we have much bigger problems than these stats being slightly stale.

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 10, 2025
@elasticsearchmachine elasticsearchmachine merged commit c02bb4d into elastic:main Jul 10, 2025
33 checks passed
@DaveCTurner DaveCTurner deleted the 2025/07/09/http-connection-metrics branch July 10, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Network Http and internode communication implementations >enhancement Team:Distributed Coordination Meta label for Distributed Coordination team v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants