-
-
Notifications
You must be signed in to change notification settings - Fork 623
Fix minor CI issues #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix minor CI issues #2183
Conversation
6624a1d
to
f22ffc8
Compare
@AndydeCleyre so just a quick comment. I haven't yet looked into the diff, still en route home from the US. @sirosen had a plan to have a stack of PRs to fix the CI. We're still in post-PyCon travels and may need a minute to regain mental capacity and decompress after so many days of intense interactions. I'll let him decide whether to pick commits from here. We already had a CI / infra fixing plan having met in person and did a lot of brainstorming over the sprints. Let's not get into trying to repeat the same effort over the next week or two? Would that be okay with you? |
Sure, and thanks for working on this. Maybe this will be useful as a reference for some bit, if not for cannibalization. |
Yes to both of the above messages! Your effort and work on this is very much appreciated, and I plan to either cherry-pick directly or create co-authored commits. But I have another full day of travel and will probably not get to look at this properly until Monday at the earliest. Everyone's help pitching in on this problem is great to see! 🙂 |
I just created #2184 with a cherry-pick from here. I'm trying to give credit where it's due and be very transparent. I think most of these fixes are good, but should be part of adding support for Python 3.12+ or support for newer pip versions. I'd like to handle that next phase by moving forward the |
- Add 3.12 to CI - Update a test which fails on 3.12 due to changes in CPython/pip behaviors, with a comment explaining why - Update the `tox` `piplowest` build to now select `pip==23.2.*` on Python 3.12+. The lowest declared supported `pip` version (`22.2.*`) does not work on 3.12. This change builds on previous efforts by other pip-tools contributors: - jazzband#2148 - jazzband#2183 Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <578543+webknjaz@users.noreply.github.com> Co-authored-by: Andy Kluger <1787385+AndydeCleyre@users.noreply.github.com>
@AndydeCleyre could you rebase so we could see what's remaining unmerged? |
- The version range for pyzmq was bumped for compatibility with newer ecosystem - The format was changed to a pyproject.toml, addressing this warning: DEPRECATION: Building 'fake_with_deps' using the legacy setup.py bdist_wheel mechanism, which will be removed in a future version. pip 25.3 will enforce this behaviour change. A possible replacement is to use the standardized build interface by setting the `--use-pep517` option, (possibly combined with `--no-build-isolation`), or adding a `pyproject.toml` file to the source tree of 'fake_with_deps'. Discussion can be found at pypa/pip#6334 The rest of the test packages may be updated accordingly in the future.
…her pip 25.1 issues) This is in order to see other tests all pass in CI during the PR review. I suggest dropping this commit before the PR is merged.
f22ffc8
to
2960d04
Compare
Sure, it's now rebased, and I've crossed out the two obsolete items from the original description. |
. . . so we can focus on more important issues.
Temporarily ignore issues Files included relatively in requirements.in file gets converted to absolute paths #2131 and pip-compile errors when generating hashes with AttributeError 'cache_clear' with pip v25.1 #2176 (and any other pip 25.1 issues)
This is in order to see other tests all pass in CI during the PR review.
I suggest dropping this commit before the PR is merged.
Stop expecting these to be specially ignored: setuptools, wheel, distributenow covered by 8d5e46eSee: Test failure:
pip freeze
no longer protectssetuptools
,distribute
orwheel
on Python 3.12+ #2104Use --strip-extras to suppress irrelevant warning for test_all_no_emit_options
Accept complaint of any missing key in a known invalid pyproject.tomlnow covered by c8fb33aThe stderr may stop after noting the missing version,
without mentioning the missing name
Introduce compatibility with click>=8.2, maintaining compatibility with <8.2
Update test pkg: fake_with_deps
DEPRECATION: Building 'fake_with_deps' using the legacy setup.py bdist_wheel mechanism,
which will be removed in a future version.
pip 25.3 will enforce this behaviour change.
A possible replacement is to use the standardized build interface
by setting the
--use-pep517
option,(possibly combined with
--no-build-isolation
),or adding a
pyproject.toml
file to the source tree of 'fake_with_deps'.Discussion can be found at Deprecate legacy
setup.py bdist_wheel
mechanism for building projects pypa/pip#6334The rest of the test packages may be updated accordingly in the future.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.