Skip to content

Fix minor CI issues #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

AndydeCleyre
Copy link
Contributor

@AndydeCleyre AndydeCleyre commented May 24, 2025

. . . so we can focus on more important issues.

Contributor checklist
  • Included tests for the changes. (No new tests. The aim is to get existing ones passing in CI.)
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@AndydeCleyre AndydeCleyre added skip-changelog Avoid listing in changelog tests Testing and related things ci Related to continuous integration tasks labels May 24, 2025
@AndydeCleyre AndydeCleyre force-pushed the fix-ci-2025-05 branch 2 times, most recently from 6624a1d to f22ffc8 Compare May 24, 2025 04:38
@AndydeCleyre AndydeCleyre requested a review from webknjaz May 24, 2025 04:44
@AndydeCleyre AndydeCleyre requested a review from sirosen May 24, 2025 04:50
@webknjaz
Copy link
Member

webknjaz commented May 24, 2025

@AndydeCleyre so just a quick comment. I haven't yet looked into the diff, still en route home from the US.

@sirosen had a plan to have a stack of PRs to fix the CI. We're still in post-PyCon travels and may need a minute to regain mental capacity and decompress after so many days of intense interactions. I'll let him decide whether to pick commits from here. We already had a CI / infra fixing plan having met in person and did a lot of brainstorming over the sprints.

Let's not get into trying to repeat the same effort over the next week or two? Would that be okay with you?

@AndydeCleyre
Copy link
Contributor Author

Sure, and thanks for working on this. Maybe this will be useful as a reference for some bit, if not for cannibalization.

@sirosen
Copy link
Member

sirosen commented May 24, 2025

Yes to both of the above messages! Your effort and work on this is very much appreciated, and I plan to either cherry-pick directly or create co-authored commits.

But I have another full day of travel and will probably not get to look at this properly until Monday at the earliest.

Everyone's help pitching in on this problem is great to see! 🙂

@sirosen
Copy link
Member

sirosen commented May 27, 2025

I just created #2184 with a cherry-pick from here. I'm trying to give credit where it's due and be very transparent.

I think most of these fixes are good, but should be part of adding support for Python 3.12+ or support for newer pip versions. I'd like to handle that next phase by moving forward the pipsupported versions and incorporating fixes (from here and possibly elsewhere). And I'd like to add Python 3.12 to the CI matrix. So I intend to inch the infrastructure forward and cherry-pick more from here, assuming that sounds good to everyone.

sirosen added a commit to sirosen/pip-tools that referenced this pull request Jun 16, 2025
- Add 3.12 to CI
- Update a test which fails on 3.12 due to changes in CPython/pip
  behaviors, with a comment explaining why
- Update the `tox` `piplowest` build to now select `pip==23.2.*`
  on Python 3.12+.

The lowest declared supported `pip` version (`22.2.*`) does not work
on 3.12.

This change builds on previous efforts by other pip-tools
contributors:
- jazzband#2148
- jazzband#2183

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <578543+webknjaz@users.noreply.github.com>
Co-authored-by: Andy Kluger <1787385+AndydeCleyre@users.noreply.github.com>
@webknjaz
Copy link
Member

@AndydeCleyre could you rebase so we could see what's remaining unmerged?

- The version range for pyzmq was bumped for compatibility with newer ecosystem
- The format was changed to a pyproject.toml, addressing this warning:

DEPRECATION: Building 'fake_with_deps' using the legacy setup.py bdist_wheel mechanism,
which will be removed in a future version.
pip 25.3 will enforce this behaviour change.
A possible replacement is to use the standardized build interface
by setting the `--use-pep517` option,
(possibly combined with `--no-build-isolation`),
or adding a `pyproject.toml` file to the source tree of 'fake_with_deps'.
Discussion can be found at pypa/pip#6334

The rest of the test packages may be updated accordingly in the future.
…her pip 25.1 issues)

This is in order to see other tests all pass in CI during the PR review.
I suggest dropping this commit before the PR is merged.
@AndydeCleyre
Copy link
Contributor Author

Sure, it's now rebased, and I've crossed out the two obsolete items from the original description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration tasks skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants