-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-5334: Image Pull Progress #5335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d1363c6
to
08e2a89
Compare
e74154d
to
82a29fb
Compare
|
||
It is expected to be implemented after the CRI implementation supporting the CRI API is released. | ||
|
||
- Add a new route `/imagePullProgress/{podNamespace}/{podID}` to the Kubelet server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is camel case typical for http endpoints like this? it seems a bit odd to me but I'm not familiar with convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is the typical camel case. I am referring to the portForward endpoint.
|
||
# The milestone at which this feature was, or is targeted to be, at each stage. | ||
milestone: | ||
alpha: "v1.35" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wzshiming it seems you're targetting 1.35 for this (as well as haven't filled out PRR). I'm going to remove milestone 1.34 from this for now
cc05430
to
6316dc7
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
692797e
to
6958275
Compare
@wzshiming: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Uh oh!
There was an error while loading. Please reload this page.