Skip to content

KEP-2837: Beta Graduation Criteria for 1.34 #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

KEP-2837: Beta Graduation Criteria for 1.34 #5362

merged 1 commit into from
Jun 19, 2025
+310 −378

Conversation

ndixita
Copy link
Contributor

@ndixita ndixita commented Jun 3, 2025 •
edited
Loading

  • One-line PR description: Update details around alignment managers, autoscalers
  • Other comments: For Beta, following features are in scope:
    • eviction manager
    • events associated with topology, memory and cpu manager to bubble up unsupported alignment operations for guaranteed pods with pod level resources
    • implementation details around HPA, VPA and cluster autoscaler
    • moved in place pod level resources resize to Adding Alpha criteria for KEP to support IPPR & Pod Level Resources #5423
    • full support for alignment managers moved to future work
    • support for windows moved to future work
    • advanced vpa algorithm to recommend proportionate pod limits with container limits moved to future work and subject to further discussions

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2025
pravk03
pravk03 reviewed Jun 3, 2025
View reviewed changes
Copy link

@pravk03 pravk03 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user attempts to configure scope=container for such a pod

Topology Manager scope (container/pod) is a node level setting.

@ndixita ndixita force-pushed the pod-level-resources-beta branch 3 times, most recently from 3da0389 to 471221b Compare June 11, 2025 23:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2025
@ndixita ndixita marked this pull request as ready for review June 11, 2025 23:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from palnabarun June 11, 2025 23:10
This was referenced Jun 11, 2025
Closed
Open
adrianmoisey
adrianmoisey reviewed Jun 12, 2025
View reviewed changes
adrianmoisey
adrianmoisey reviewed Jun 12, 2025
View reviewed changes
@ndixita
Copy link
Contributor Author

ndixita commented Jun 12, 2025

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Jun 12, 2025
@ndixita ndixita force-pushed the pod-level-resources-beta branch from b776557 to 3f3e191 Compare June 12, 2025 17:13
@ndixita
Copy link
Contributor Author

ndixita commented Jun 12, 2025

/assign @tallclair

haircommander
haircommander reviewed Jun 12, 2025
View reviewed changes
haircommander
haircommander reviewed Jun 12, 2025
View reviewed changes
@ndixita ndixita force-pushed the pod-level-resources-beta branch from 3f3e191 to 5e556cc Compare June 12, 2025 20:12
@ndixita ndixita changed the title Adding details for CPU, memory and topology manager implementation an… KEP-2837: Beta Graduation Criteria Jun 12, 2025
@ndixita ndixita force-pushed the pod-level-resources-beta branch from 7a26908 to 5773936 Compare June 18, 2025 22:41
tallclair
tallclair reviewed Jun 18, 2025
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@ndixita ndixita force-pushed the pod-level-resources-beta branch from 5773936 to 5b51362 Compare June 18, 2025 23:16
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@ndixita ndixita force-pushed the pod-level-resources-beta branch from 5b51362 to 1d8e4df Compare June 18, 2025 23:24
@mrunalp
Copy link
Contributor

mrunalp commented Jun 18, 2025

Can we summarize in the description and/or the commit message the proposed changes (some are lost in the discussion threads)?

@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@ndixita ndixita force-pushed the pod-level-resources-beta branch from 1d8e4df to 83bf364 Compare June 19, 2025 06:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
soltysh
soltysh reviewed Jun 19, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 PRR questions (tests for enablement/disablement, upgrade->downgrade->upgrade and new fields estimation) are the remaining blocking items.

keps/sig-node/2837-pod-level-resource-spec/README.md
@@ -71,7 +72,7 @@
- [Implementation History](#implementation-history)
- [Drawbacks](#drawbacks)
- [Alternatives](#alternatives)
- [VPA](#vpa)
- [VPA](#vpa-1)
<!-- /toc -->


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to include the second one in the release, it's currently missing lead-opted-in label and milestone set. This needs to be done by sig-node leads.

keps/sig-node/2837-pod-level-resource-spec/README.md
* Pod Level Resources Support With In Place Pod Vertical Scaling KEP is past alpha.
* User feedback (ideally from at least two distinct users) is green
* Resource Allocation Managers i.e. Topology, Memory and CPU managers support with
Pod-level resources is past alpha.
### Upgrade / Downgrade Strategy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In ###### Are there any tests for feature enablement/disablement? you're describing tests that were planned for alpha, can you add there links to those tests?
  2. ###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested? is missing answers, it currently mentions only that it will be tested? Was it? Can you describe the steps?
  3. In ###### Will enabling / using this feature result in increasing size or count of the existing API objects? you're missing estimated size increase, and amount of new objects (see comments above that section)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the concerns.

raywainman
raywainman reviewed Jun 19, 2025
View reviewed changes
Copy link

@raywainman raywainman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for SIG-Autoscaling

@ndixita ndixita force-pushed the pod-level-resources-beta branch from 83bf364 to 88c0e23 Compare June 19, 2025 17:18
@jackfrancis jackfrancis dismissed sanposhiho’s stale review June 19, 2025 17:27

@sanposhiho lgmt'd PR after @ndixita resolved the review feedback

@ndixita ndixita force-pushed the pod-level-resources-beta branch from 88c0e23 to a088c6e Compare June 19, 2025 17:34
@ndixita
Adding Beta implementation requirements
e8c51a7 
Signed-off-by: ndixita <ndixita@google.com>
@ndixita ndixita force-pushed the pod-level-resources-beta branch from a088c6e to e8c51a7 Compare June 19, 2025 17:36
@jackfrancis
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@jackfrancis
Copy link

/assign @soltysh @deads2k

soltysh
soltysh approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
the PRR section

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mrunalp, ndixita, sanposhiho, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit ef7e11d into kubernetes:master Jun 19, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@raywainman raywainman raywainman left review comments

@adrianmoisey adrianmoisey adrianmoisey left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@aaron-prindle aaron-prindle aaron-prindle left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@pravk03 pravk03 pravk03 left review comments

@ffromani ffromani ffromani left review comments

@toVersus toVersus toVersus left review comments

@tallclair tallclair tallclair left review comments

@sanposhiho sanposhiho sanposhiho left review comments

@soltysh soltysh soltysh approved these changes

@mrunalp mrunalp mrunalp approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@palnabarun palnabarun Awaiting requested review from palnabarun

@jonathan-innis jonathan-innis Awaiting requested review from jonathan-innis

Assignees

@soltysh soltysh

@jackfrancis jackfrancis

@deads2k deads2k

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.