-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements #5409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements #5409
Conversation
@roycaihw: GitHub didn't allow me to request PR reviews from the following users: tiraboschi. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements |
b399df8
to
1757134
Compare
@haircommander I've updated the two KEPs as suggested. PTAL
|
one note but generally this LGTM |
PRR shadow:
|
PRR lgtm. /approve |
|
||
# The following PRR answers are required at alpha release | ||
# List the feature gate name and the components for which it must be enabled | ||
feature-gates: | ||
- name: PSINodeCondition | ||
- name: KubeletPSI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for posterity: this was already done for alpha, we're not changing the feature gate name
/lgtm |
Also update the KEP to reflect the Alpha implementation details
7135412
to
ec090f0
Compare
I took over the last comment https://github.com/kubernetes/enhancements/pull/5409/files#r2155728798 in #5427 , which leaves nothing outstanding here /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mrunalp, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KEP-4205: add blurb about PSI performance on top of #5409
/sig node
/cc @haircommander @ndixita @tiraboschi