Skip to content

Translate the UI to Persian #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ebraminio
Copy link

@ebraminio ebraminio commented May 20, 2025

It works in a terminal with support of bidi (the screenshot below is from Terminal.app when #72 is applied)

LANG=fa cargo run

image

I'm aware of #37, this isn't related to editing of RTL documents but just localization for a language with RTL script.

About the translation itself, translation of "Alt", "Ctrl" and "Shift" come from https://persian-computing.org/archives/ISIRI/ISIRI-9147.pdf page 19 (kept untranslated as below)

This translation tries to follow:

If you want to review the translation itself please check these sources for making sure we are on the same page.

@ebraminio ebraminio force-pushed the persian-translation branch 3 times, most recently from a9c8e3c to 4a7ba33 Compare May 20, 2025 08:44
@ebraminio
Copy link
Author

@microsoft-github-policy-service agree

@avestura
Copy link

avestura commented May 20, 2025

My 2 cents here: I understand that Institute of Standards and Industrial Research translated keys like "Control" to "مهار", but in my personal experience I haven't seen any adaptation of these translations in any Persian app. I'm pretty sure people will be confused of that translation, and the same doc ISIRI-9147.pdf used the word "کنترل" multiple times all over the document. That said, I do believe that "مهار" is a more beautiful word and maybe this is where its adaptation can begin (: The alternative would be to just not translate it and leave it as is, just like how "LF" and "UTF-8" are not translated and remained in English.

ebraminio added a commit to ebraminio/edit that referenced this pull request May 20, 2025
@ebraminio
Copy link
Author

My 2 cents here: I understand that Institute of Standards and Industrial Research translated keys like "Control" to "مهار", but in my personal experience I haven't seen any adaptation of these translations in any Persian app. I'm pretty sure people will be confused of that translation, and the same doc ISIRI-9147.pdf used the word "کنترل" multiple times all over the document. That said, I do believe that "مهار" is a more beautiful word and maybe this is where it's adaptation can begin (: The alternative would be to just not translate it and leave it as is, just like how "LF" and "UTF-8" are not translated and remained in English.

Makes sense, just made the Ctrl, Shift and Alt untranslated just like some of the other languages, please review the changes again. Thanks 🙏

@avestura
Copy link

Makes sense, just made the Ctrl, Shift and Alt untranslated just like some of the other languages, please review the changes again. Thanks 🙏

Looks good to me. Thank you.

ebraminio added a commit to ebraminio/edit that referenced this pull request May 20, 2025
@ebraminio ebraminio force-pushed the persian-translation branch from 71b9bb0 to c57b33b Compare May 20, 2025 19:44
ebraminio added a commit to ebraminio/edit that referenced this pull request May 20, 2025
@ebraminio ebraminio force-pushed the persian-translation branch from c57b33b to 0ae31ba Compare May 20, 2025 19:45
@lhecker
Copy link
Member

lhecker commented May 20, 2025

Hi! I've received several PRs for translations since yesterday. As you may have read, a small binary size is an important goal. Long-term this forces me to decide which languages to bundle with the editor. It also shouldn't be such a large number of localizations that maintenance becomes a burden. For instance, I only speak 2 languages, so any strings I add will be translated using LLMs most likely.

But simultaneously, I don't want to reject languages that people are willing to maintain, or those that people are interested in. I think I need a few days to think about this and a bit time to toy around with #165. If you have any input to that issue, please let me know over there. I apologize for the delay but am very grateful that you took your time to do this. 🙂

@lhecker lhecker added the A-localization Area: Localization label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-localization Area: Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants