Allow find and replace with an empty string #442
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the replace field is empty, the write function will do nothing, and hitting enter will simply go through the occurrences replacing nothing.
Allowing the replace string to be empty, allows the user to use find and replace to rapidly erase text.
Since write specifically checks if string is empty, we could consider allowing an empty write, which does work in testing, but we can instead utilise extract_selection here instead. This is a bit more explicit and ensures this change only affects find and replace.
Closes #439