Add title for the Document Picker dialog for consistency #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikitf777
force-pushed
the
document-picker-title
branch
from
a4afd69 to
e9ed598
Compare
Nikitf777
changed the title
|
Your criticism is IMO 100% justified, but "Document Picker..." as a dialog title sounds completely wrong. It would need to be an active command such as "Switch document..." similar to "Open File...". The formatting of the code is also wrong unfortunately (run |
|
I'll close this PR in advance. |
lhecker
added a commit
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks weird for me that the Document Picker dialog doesn't have a title. Especially when any other dialog menu has one. The PR fixes it.